From: Al Viro <viro@zeniv.linux.org.uk>
To: Siddhesh Poyarekar <siddhesh@gotplt.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH] proc: Escape more characters in /proc/mounts output
Date: Tue, 15 Dec 2020 06:10:05 +0000 [thread overview]
Message-ID: <20201215061005.GF3579531@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20201215042454.998361-1-siddhesh@gotplt.org>
On Tue, Dec 15, 2020 at 09:54:54AM +0530, Siddhesh Poyarekar wrote:
> + get_user(byte, (const char __user *)data);
> +
> + return byte ? strndup_user(data, PATH_MAX) : NULL;
> }
No. Not to mention anything else, you
* fetch the same data twice
* fail to check the get_user() results
next prev parent reply other threads:[~2020-12-15 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-15 4:24 [PATCH] proc: Escape more characters in /proc/mounts output Siddhesh Poyarekar
2020-12-15 6:10 ` Al Viro [this message]
2020-12-15 7:30 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201215061005.GF3579531@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=fweimer@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=siddhesh@gotplt.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).