From: Christoph Hellwig <hch@infradead.org>
To: Jeffle Xu <jefflexu@linux.alibaba.com>
Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
joseph.qi@linux.alibaba.com
Subject: Re: [PATCH] block: move definition of blk_qc_t to types.h
Date: Tue, 22 Dec 2020 13:30:53 +0000 [thread overview]
Message-ID: <20201222133053.GA2935@infradead.org> (raw)
In-Reply-To: <20201222031154.62150-1-jefflexu@linux.alibaba.com>
> -typedef unsigned int blk_qc_t;
> #define BLK_QC_T_NONE -1U
> #define BLK_QC_T_SHIFT 16
> #define BLK_QC_T_INTERNAL (1U << 31)
I think we need a comment here explaining these are the values for
blk_qc_t at least.
next prev parent reply other threads:[~2020-12-22 13:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-22 3:11 [PATCH] block: move definition of blk_qc_t to types.h Jeffle Xu
2020-12-22 13:30 ` Christoph Hellwig [this message]
2020-12-23 1:02 ` JeffleXu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201222133053.GA2935@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=jefflexu@linux.alibaba.com \
--cc=joseph.qi@linux.alibaba.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).