From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E43DC433E0 for ; Tue, 22 Dec 2020 13:31:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0C64623133 for ; Tue, 22 Dec 2020 13:31:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727459AbgLVNbR (ORCPT ); Tue, 22 Dec 2020 08:31:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727006AbgLVNbQ (ORCPT ); Tue, 22 Dec 2020 08:31:16 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89821C0613D6; Tue, 22 Dec 2020 05:31:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=42fzafLRxdLNbzacrFdM4qrpWHImldmnOrdNk/6ZVck=; b=iePoeRjEV0kcCjWEwPHuCUm1iq DsnCh6wlOMy9pj7bxofpZcd6sMzCSd2I/GgHLbXe4+d47bGf8PoYmhaWHX4JAljs7Pmp11Q61zZry uNBn6b2e9O7Ol30xD2+f25f/OKKo2EejBCMSi4aXnQWCWGJcyN7m5KeZkWhfJKK8x6qocjLrF9eK1 HuGXF8R0AhSu2kId/AcyD/guIzYRawRmiUACVaunqnykwQLtLbuUJiBWDZwM1zc3OyBhtUOWuhfLW utOSM4ESay1lTFxwSK16xqDEiDyUT1DDFnMXTzCKwbMnLypMRHujdLLBoRjOiVAFdvst9fpmxG+0d rCC+BbMA==; Received: from hch by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1krhkb-0001K5-MZ; Tue, 22 Dec 2020 13:30:53 +0000 Date: Tue, 22 Dec 2020 13:30:53 +0000 From: Christoph Hellwig To: Jeffle Xu Cc: axboe@kernel.dk, viro@zeniv.linux.org.uk, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, joseph.qi@linux.alibaba.com Subject: Re: [PATCH] block: move definition of blk_qc_t to types.h Message-ID: <20201222133053.GA2935@infradead.org> References: <20201222031154.62150-1-jefflexu@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201222031154.62150-1-jefflexu@linux.alibaba.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org > -typedef unsigned int blk_qc_t; > #define BLK_QC_T_NONE -1U > #define BLK_QC_T_SHIFT 16 > #define BLK_QC_T_INTERNAL (1U << 31) I think we need a comment here explaining these are the values for blk_qc_t at least.