From: Dmitrii Tcvetkov <me@demsh.org>
To: djwong@kernel.org
Cc: david@fromorbit.com, hch@lst.de, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org,
sandeen@sandeen.net, torvalds@linux-foundation.org
Subject: Re: [GIT PULL] xfs: new code for 5.11
Date: Tue, 29 Dec 2020 10:49:55 +0300 [thread overview]
Message-ID: <20201229104955.565423f9@note> (raw)
In-Reply-To: <20201218171242.GH6918@magnolia>
In-Reply-To: <20201218171242.GH6918@magnolia>
>Please pull the following branch containing all the new xfs code for
>5.11. In this release we add the ability to set a 'needsrepair' flag
>indicating that we /know/ the filesystem requires xfs_repair, but other
>than that, it's the usual strengthening of metadata validation and
>miscellaneous cleanups.
>...
>New code for 5.11:
>- Introduce a "needsrepair" "feature" to flag a filesystem as needing a
> pass through xfs_repair. This is key to enabling filesystem upgrades
> (in xfs_db) that require xfs_repair to make minor adjustments to
>metadata.
Hello.
Most likely I miss something obvious but according to xfs_repair(8):
BUGS:
The filesystem to be checked and repaired must have been unmounted
cleanly using normal system administration procedures (the
umount(8) command or system shutdown), not as a result of a
crash or system reset. If the filesystem has not been unmounted
cleanly, mount it and unmount it cleanly before running xfs_repair.
which is there since commit d321ceac "add libxlog directory"
Date: Wed Oct 17 11:00:32 2001 +0000 in xfsprogs-dev[1].
So will be there situation of uncleanly unmounted filesystem with
"needsrepair" bit set? Will one be able to mount and umount it before
running xfs_repair in that case?
[1] git://git.kernel.org/pub/scm/fs/xfs/xfsprogs-dev.git
next prev parent reply other threads:[~2020-12-29 7:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-18 17:12 [GIT PULL] xfs: new code for 5.11 Darrick J. Wong
2020-12-18 20:54 ` pr-tracker-bot
2020-12-29 7:49 ` Dmitrii Tcvetkov [this message]
2020-12-31 22:52 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201229104955.565423f9@note \
--to=me@demsh.org \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).