Re: [PATCH v16 09/10] fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4728 bytes --]

Hi Konstantin,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.11-rc1 next-20201223]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Konstantin-Komarov/NTFS-read-write-driver-GPL-implementation-by-Paragon-Software/20201225-215909
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 71c5f03154ac1cb27423b984743ccc2f5d11d14d
config: mips-randconfig-r022-20201229 (attached as .config)
compiler: mips64el-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/fafee24e48a76d7a2f856437aa0480ecfe72bec6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Konstantin-Komarov/NTFS-read-write-driver-GPL-implementation-by-Paragon-Software/20201225-215909
        git checkout fafee24e48a76d7a2f856437aa0480ecfe72bec6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from fs/ntfs3/attrib.c:18:
>> fs/ntfs3/ntfs.h:427:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     427 | static const inline __le16 *attr_name(const struct ATTRIB *attr)
         | ^~~~~~
   fs/ntfs3/ntfs.h:544:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     544 | static const inline __le16 *le_name(const struct ATTR_LIST_ENTRY *le)
         | ^~~~~~
   fs/ntfs3/attrib.c: In function 'attr_data_get_block':
>> fs/ntfs3/attrib.c:832:6: warning: variable 'new_size' set but not used [-Wunused-but-set-variable]
     832 |  u64 new_size, total_size;
         |      ^~~~~~~~
--
   In file included from fs/ntfs3/attrlist.c:14:
>> fs/ntfs3/ntfs.h:427:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     427 | static const inline __le16 *attr_name(const struct ATTRIB *attr)
         | ^~~~~~
   fs/ntfs3/ntfs.h:544:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     544 | static const inline __le16 *le_name(const struct ATTR_LIST_ENTRY *le)
         | ^~~~~~
--
   In file included from fs/ntfs3/file.c:17:
>> fs/ntfs3/ntfs.h:427:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     427 | static const inline __le16 *attr_name(const struct ATTRIB *attr)
         | ^~~~~~
   fs/ntfs3/ntfs.h:544:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     544 | static const inline __le16 *le_name(const struct ATTR_LIST_ENTRY *le)
         | ^~~~~~
   fs/ntfs3/file.c: In function 'ntfs_truncate':
>> fs/ntfs3/file.c:410:6: warning: variable 'vcn' set but not used [-Wunused-but-set-variable]
     410 |  u32 vcn;
         |      ^~~
--
   In file included from fs/ntfs3/index.c:14:
>> fs/ntfs3/ntfs.h:427:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     427 | static const inline __le16 *attr_name(const struct ATTRIB *attr)
         | ^~~~~~
   fs/ntfs3/ntfs.h:544:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     544 | static const inline __le16 *le_name(const struct ATTR_LIST_ENTRY *le)
         | ^~~~~~
>> fs/ntfs3/index.c:542:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     542 | static const inline struct NTFS_DE *hdr_find_split(const struct INDEX_HDR *hdr)
         | ^~~~~~
   fs/ntfs3/index.c:573:1: warning: 'inline' is not at beginning of declaration [-Wold-style-declaration]
     573 | static const inline struct NTFS_DE *
         | ^~~~~~


vim +/inline +427 fs/ntfs3/ntfs.h

4ba58550cb5849a Konstantin Komarov 2020-12-25  426  
4ba58550cb5849a Konstantin Komarov 2020-12-25 @427  static const inline __le16 *attr_name(const struct ATTRIB *attr)
4ba58550cb5849a Konstantin Komarov 2020-12-25  428  {
4ba58550cb5849a Konstantin Komarov 2020-12-25  429  	return Add2Ptr(attr, le16_to_cpu(attr->name_off));
4ba58550cb5849a Konstantin Komarov 2020-12-25  430  }
4ba58550cb5849a Konstantin Komarov 2020-12-25  431  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 28435 bytes --]