linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, linux-fsdevel@vger.kernel.org
Subject: Re: [vfs:work.elf-compat 11/13] fs/binfmt_elf.c:254: undefined reference to `vdso_image_32'
Date: Mon, 4 Jan 2021 23:03:54 +0000	[thread overview]
Message-ID: <20210104230354.GP3579531@ZenIV.linux.org.uk> (raw)
In-Reply-To: <202101041818.RRAoU6Bu-lkp@intel.com>

On Mon, Jan 04, 2021 at 06:13:25PM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git work.elf-compat
> head:   b9613abdecd9d2dae95f4712985280c80ce8e646
> commit: 5df3c15125233fbc59fd003249c381c7edd985cc [11/13] Kconfig: regularize selection of CONFIG_BINFMT_ELF
> config: x86_64-randconfig-a005-20210104 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> reproduce (this is a W=1 build):
>         # https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git/commit/?id=5df3c15125233fbc59fd003249c381c7edd985cc
>         git remote add vfs https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git
>         git fetch --no-tags vfs work.elf-compat
>         git checkout 5df3c15125233fbc59fd003249c381c7edd985cc
>         # save the attached .config to linux build tree
>         make W=1 ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    ld: fs/compat_binfmt_elf.o: in function `create_elf_tables':
> >> fs/binfmt_elf.c:254: undefined reference to `vdso_image_32'
> >> ld: fs/binfmt_elf.c:254: undefined reference to `vdso_image_32'
> >> ld: fs/binfmt_elf.c:254: undefined reference to `vdso_image_32'

Bloody wonderful.  Background: right now in mainline selecting X32
without IA32_EMULATION ends up with being unable to execute x32
binaries.  Which is the reason why that build breakage does not
happen there.  It's not hard to fix (just turn the else branch of
COMPAT_ARCH_DLINFO into else if (IS_ENABLED(CONFIG_IA32_EMULATION));
absent IA32_EMULATION compat_elf_check_arch() will reject anything
that doesn't have exec->e_machine == EM_X86_64, so that else is
dead code on such configs anyway).

Let me check if such configs (X32, !IA32_EMULATION, 64bit
userland with some x32 binaries) boot and work; if that fix
is all it takes, I'll throw it into the series next to other
x32 commits...

      reply	other threads:[~2021-01-04 23:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-04 10:13 [vfs:work.elf-compat 11/13] fs/binfmt_elf.c:254: undefined reference to `vdso_image_32' kernel test robot
2021-01-04 23:03 ` Al Viro [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210104230354.GP3579531@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).