From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A943AC433DB for ; Fri, 8 Jan 2021 09:16:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 61F4322BEA for ; Fri, 8 Jan 2021 09:16:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727991AbhAHJQH (ORCPT ); Fri, 8 Jan 2021 04:16:07 -0500 Received: from verein.lst.de ([213.95.11.211]:43183 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727776AbhAHJQH (ORCPT ); Fri, 8 Jan 2021 04:16:07 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id C5B1468AFE; Fri, 8 Jan 2021 10:15:24 +0100 (CET) Date: Fri, 8 Jan 2021 10:15:22 +0100 From: Christoph Hellwig To: Eric Biggers Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Theodore Ts'o , Christoph Hellwig Subject: Re: [PATCH 12/13] xfs: remove a stale comment from xfs_file_aio_write_checks() Message-ID: <20210108091522.GD2587@lst.de> References: <20210105005452.92521-1-ebiggers@kernel.org> <20210105005452.92521-13-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210105005452.92521-13-ebiggers@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jan 04, 2021 at 04:54:51PM -0800, Eric Biggers wrote: > From: Eric Biggers > > The comment in xfs_file_aio_write_checks() about calling file_modified() > after dropping the ilock doesn't make sense, because the code that > unconditionally acquires and drops the ilock was removed by > commit 467f78992a07 ("xfs: reduce ilock hold times in > xfs_file_aio_write_checks"). > > Remove this outdated comment. Yes, this looks good, I actually have the removal included in a WIP patch as well, but splitting it out like this look good to me: Reviewed-by: Christoph Hellwig