From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 446ACC43381 for ; Mon, 11 Jan 2021 17:51:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C6E3225AB for ; Mon, 11 Jan 2021 17:51:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390017AbhAKRut (ORCPT ); Mon, 11 Jan 2021 12:50:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389923AbhAKRut (ORCPT ); Mon, 11 Jan 2021 12:50:49 -0500 Received: from ZenIV.linux.org.uk (zeniv.linux.org.uk [IPv6:2002:c35c:fd02::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBE5FC061794; Mon, 11 Jan 2021 09:50:08 -0800 (PST) Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kz1KN-009KiU-Fr; Mon, 11 Jan 2021 17:50:03 +0000 Date: Mon, 11 Jan 2021 17:50:03 +0000 From: Al Viro To: Christoph Hellwig Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, David Laight Subject: Re: [PATCH] iov_iter: fix the uaccess area in copy_compat_iovec_from_user Message-ID: <20210111175003.GA3579531@ZenIV.linux.org.uk> References: <20210111171926.1528615-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210111171926.1528615-1-hch@lst.de> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Jan 11, 2021 at 06:19:26PM +0100, Christoph Hellwig wrote: > sizeof needs to be called on the compat pointer, not the native one. > > Fixes: 89cd35c58bc2 ("iov_iter: transparently handle compat iovecs in import_iovec") > Reported-by: David Laight > Signed-off-by: Christoph Hellwig Applied.