From: Christoph Hellwig <hch@lst.de>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-block@vger.kernel.org, 'Jens Axboe ' <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] block: Add bio_limit
Date: Mon, 18 Jan 2021 19:13:38 +0100 [thread overview]
Message-ID: <20210118181338.GA11002@lst.de> (raw)
In-Reply-To: <20210114194706.1905866-1-willy@infradead.org>
On Thu, Jan 14, 2021 at 07:47:06PM +0000, Matthew Wilcox (Oracle) wrote:
> It's often inconvenient to use BIO_MAX_PAGES due to min() requiring the
> sign to be the same. Introduce bio_limit() and change BIO_MAX_PAGES to
> be unsigned to make it easier for the users.
>
> Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
I like the helper, but I'm not too happy with the naming. Why not
something like bio_guess_nr_segs() or similar?
next prev parent reply other threads:[~2021-01-18 18:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 19:47 [PATCH] block: Add bio_limit Matthew Wilcox (Oracle)
2021-01-18 18:13 ` Christoph Hellwig [this message]
2021-01-18 18:17 ` Matthew Wilcox
2021-01-18 18:31 ` Christoph Hellwig
2021-01-18 19:20 ` Matthew Wilcox
2021-01-18 23:52 ` Damien Le Moal
2021-01-19 6:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210118181338.GA11002@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).