From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: Matthew Wilcox <willy@infradead.org>,
Christoph Hellwig <hch@lst.de>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
'Jens Axboe ' <axboe@kernel.dk>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] block: Add bio_limit
Date: Tue, 19 Jan 2021 07:12:53 +0100 [thread overview]
Message-ID: <20210119061253.GA21250@lst.de> (raw)
In-Reply-To: <BL0PR04MB6514A4BFE2EA5AE59795E586E7A40@BL0PR04MB6514.namprd04.prod.outlook.com>
On Mon, Jan 18, 2021 at 11:52:10PM +0000, Damien Le Moal wrote:
> What about calling it bio_max_bvecs() or bio_max_segs() ? Together with renaming
> BIO_MAX_PAGES to BIO_MAX_SEGS or BIO_MAX_BVECS, things would be clear on what
> this is referring to. Since these days one bvec is one seg, but segment is more
> struct request layer while bvec is more BIO layer, I would lean toward using
> bvec for naming this one, but either way would be fine I think.
That's probably the least bad of the options for now.
prev parent reply other threads:[~2021-01-19 6:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-14 19:47 [PATCH] block: Add bio_limit Matthew Wilcox (Oracle)
2021-01-18 18:13 ` Christoph Hellwig
2021-01-18 18:17 ` Matthew Wilcox
2021-01-18 18:31 ` Christoph Hellwig
2021-01-18 19:20 ` Matthew Wilcox
2021-01-18 23:52 ` Damien Le Moal
2021-01-19 6:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210119061253.GA21250@lst.de \
--to=hch@lst.de \
--cc=Damien.LeMoal@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).