From: Christoph Hellwig <hch@lst.de>
To: Maxim Mikityanskiy <maxtram95@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>,
linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "block: simplify set_init_blocksize" to regain lost performance
Date: Wed, 27 Jan 2021 17:12:05 +0100 [thread overview]
Message-ID: <20210127161205.GA21325@lst.de> (raw)
In-Reply-To: <20210126195907.2273494-1-maxtram95@gmail.com>
While this code is gross, I think we need to add it back for now:
Acked-by: Christoph Hellwig <hch@lst.de>
I'll put converting the block device buffered I/O path to iomap or
an iomap lookalike on the backburner to fix this..
next prev parent reply other threads:[~2021-01-27 16:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 19:59 [PATCH] Revert "block: simplify set_init_blocksize" to regain lost performance Maxim Mikityanskiy
2021-01-27 4:23 ` Bart Van Assche
2021-01-27 7:44 ` Maxim Mikityanskiy
2021-01-27 15:18 ` Ming Lei
2021-01-27 16:12 ` Christoph Hellwig [this message]
2021-01-27 16:15 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210127161205.GA21325@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxtram95@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).