From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E0A1C433DB for ; Sat, 30 Jan 2021 06:04:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4A8A64E08 for ; Sat, 30 Jan 2021 06:04:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233830AbhA3GEV (ORCPT ); Sat, 30 Jan 2021 01:04:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43138 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233819AbhA3GD3 (ORCPT ); Sat, 30 Jan 2021 01:03:29 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0D9AC06174A; Fri, 29 Jan 2021 22:02:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ulTijpS/LBioTo1ylP63hfNPHictEmvbFArlgqbeXJ4=; b=Q9MbYBzNEQZYWZvGwWOsx22FSO 74ZfFFf55AQJeccITM31kpIlwKmqk+Fi8PqbcdgJq2RagZh5MFfS9QuEX1VkV4pM9u/mOwsWQRv12 gRFPAwWeKlAhxnlsvw5Oc3mv6uXEvBGjx5bozyZpLzmZGw1gszCnIADoBMQr+w+NWHdxZ9vX+P7Ll QOMu5DSYUkrBJntwqJlUiVOkV6lCD3oo/NXqxC5e8z4XcvjdGlucb/4chrHY59tA4RcwduDv9QVAE TbryHhGqJ9vIxgG7SKg9fnqc3FF9iCrnhT2ZJUhhPjPmmLA37CUYxPZY/d9ow5McNMpe0STttFhkq 2KeNw8Ng==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1l5jLD-00AlNA-98; Sat, 30 Jan 2021 06:02:39 +0000 Date: Sat, 30 Jan 2021 06:02:39 +0000 From: Christoph Hellwig To: "J. Bruce Fields" Cc: Christoph Hellwig , "J. Bruce Fields" , linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Trond Myklebust , Anna Schumaker , Chuck Lever Subject: Re: [PATCH 2/2 v2] nfsd: skip some unnecessary stats in the v4 case Message-ID: <20210130060239.GB2564543@infradead.org> References: <1611084297-27352-1-git-send-email-bfields@redhat.com> <1611084297-27352-3-git-send-email-bfields@redhat.com> <20210120084638.GA3678536@infradead.org> <20210121202756.GA13298@pick.fieldses.org> <20210122082059.GA119852@infradead.org> <20210129192629.GC8033@fieldses.org> <20210129192701.GD8033@fieldses.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210129192701.GD8033@fieldses.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Jan 29, 2021 at 02:27:01PM -0500, J. Bruce Fields wrote: > From: "J. Bruce Fields" > > In the typical case of v4 and an i_version-supporting filesystem, we can > skip a stat which is only required to fake up a change attribute from > ctime. > > Signed-off-by: J. Bruce Fields Looks good, Reviewed-by: Christoph Hellwig