From: Matthew Wilcox <willy@infradead.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Kalesh Singh <kaleshsingh@google.com>,
jannh@google.com, jeffv@google.com, keescook@chromium.org,
surenb@google.com, minchan@kernel.org, hridya@google.com,
rdunlap@infradead.org, christian.koenig@amd.com,
kernel-team@android.com, Jonathan Corbet <corbet@lwn.net>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>,
Alexey Gladkov <gladkov.alexey@gmail.com>,
NeilBrown <neilb@suse.de>, Anand K Mistry <amistry@google.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Michel Lespinasse <walken@google.com>,
Bernd Edlinger <bernd.edlinger@hotmail.de>,
Andrei Vagin <avagin@gmail.com>,
Yafang Shao <laoar.shao@gmail.com>,
Christian Brauner <christian.brauner@ubuntu.com>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-doc@vger.kernel.org
Subject: Re: [PATCH v5 2/2] procfs/dmabuf: Add inode number to /proc/*/fdinfo
Date: Mon, 8 Feb 2021 17:24:03 +0000 [thread overview]
Message-ID: <20210208172403.GT308988@casper.infradead.org> (raw)
In-Reply-To: <20210208171734.GA42740@localhost.localdomain>
On Mon, Feb 08, 2021 at 08:17:34PM +0300, Alexey Dobriyan wrote:
> On Mon, Feb 08, 2021 at 03:22:44PM +0000, Matthew Wilcox wrote:
> > On Mon, Feb 08, 2021 at 03:14:28PM +0000, Kalesh Singh wrote:
> > > - seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\n",
> > > + seq_printf(m, "pos:\t%lli\nflags:\t0%o\nmnt_id:\t%i\ninode_no:\t%lu\n",
> >
> > You changed it everywhere but here ...
>
> call it "st_ino", because that's how fstat calls it?
it's called "st_ino" because it's part of the stat structure.
here, it is not part of the stat structure.
prev parent reply other threads:[~2021-02-08 17:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-08 15:14 [PATCH v5 1/2] procfs: Allow reading fdinfo with PTRACE_MODE_READ Kalesh Singh
2021-02-08 15:14 ` [PATCH v5 2/2] procfs/dmabuf: Add inode number to /proc/*/fdinfo Kalesh Singh
2021-02-08 15:22 ` Matthew Wilcox
2021-02-08 15:30 ` Kalesh Singh
2021-02-08 17:17 ` Alexey Dobriyan
2021-02-08 17:24 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210208172403.GT308988@casper.infradead.org \
--to=willy@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=amistry@google.com \
--cc=avagin@gmail.com \
--cc=bernd.edlinger@hotmail.de \
--cc=christian.brauner@ubuntu.com \
--cc=christian.koenig@amd.com \
--cc=corbet@lwn.net \
--cc=ebiederm@xmission.com \
--cc=gladkov.alexey@gmail.com \
--cc=hridya@google.com \
--cc=jannh@google.com \
--cc=jeffv@google.com \
--cc=kaleshsingh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-team@android.com \
--cc=laoar.shao@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab+huawei@kernel.org \
--cc=mhocko@suse.com \
--cc=minchan@kernel.org \
--cc=neilb@suse.de \
--cc=rdunlap@infradead.org \
--cc=surenb@google.com \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).