From: David Sterba <dsterba@suse.cz>
To: ira.weiny@intel.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
clm@fb.com, josef@toxicpanda.com,
Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH V2 0/8] btrfs: convert kmaps to core page calls
Date: Thu, 11 Feb 2021 20:38:03 +0100 [thread overview]
Message-ID: <20210211193803.GH1993@suse.cz> (raw)
In-Reply-To: <20210210062221.3023586-1-ira.weiny@intel.com>
On Tue, Feb 09, 2021 at 10:22:13PM -0800, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> Changes from V1:
> Rework commit messages because they were very weak
> Change 'fs/btrfs: X' to 'btrfs: x'
> https://lore.kernel.org/lkml/20210209151442.GU1993@suse.cz/
> Per Andrew
> Split out changes to highmem.h
> The addition memcpy, memmove, and memset page functions
> The change from kmap_atomic to kmap_local_page
> The addition of BUG_ON
> The conversion of memzero_page to zero_user in iov_iter
> Change BUG_ON to VM_BUG_ON
> While we are refactoring adjust the line length down per Chaitany
>
>
> There are many places where kmap/<operation>/kunmap patterns occur. We lift a
> couple of these patterns to the core common functions and use them as well as
> existing core functions in the btrfs file system. At the same time we convert
> those core functions to use kmap_local_page() which is more efficient in those
> calls.
>
> Per the conversation on V1 it looks like Andrew would like this to go through
> the btrfs tree. I think that is fine. The other users of
> memcpy_[to|from]_page are probably not ready and I believe could be taken in an
> early rc after David submits.
>
> Is that ok with you David?
Yes.
The branch is now in
https://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git/log/?h=kmap-conversion
let me know if I've missed acked-by or reviewed-by, I added those sent
to the mailinglist and added mine to the btrfs ones and to the iov_iter
patch.
I'll add the patchset to my for-next so it gets picked by linux-next and
will keep testing it for at least a week.
Though this is less than the expected time before merge window, the
reasoning is that it's exporting helpers that are going to be used in
various subsystems. The changes in btrfs are simple and would allow to
focus on the other less trivial conversions. ETA for the pull request is
mid of the 2nd week of the merge window or after rc1.
next prev parent reply other threads:[~2021-02-11 19:40 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-10 6:22 [PATCH V2 0/8] btrfs: convert kmaps to core page calls ira.weiny
2021-02-10 6:22 ` [PATCH V2 1/8] mm/highmem: Lift memcpy_[to|from]_page to core ira.weiny
2021-02-10 6:33 ` Chaitanya Kulkarni
2021-02-10 12:53 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 2/8] mm/highmem: Convert memcpy_[to|from]_page() to kmap_local_page() ira.weiny
2021-02-10 6:37 ` Chaitanya Kulkarni
2021-02-10 12:54 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 3/8] mm/highmem: Introduce memcpy_page(), memmove_page(), and memset_page() ira.weiny
2021-02-10 6:46 ` Chaitanya Kulkarni
2021-02-10 12:54 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 4/8] mm/highmem: Add VM_BUG_ON() to mem*_page() calls ira.weiny
2021-02-10 6:57 ` Chaitanya Kulkarni
2021-02-10 16:31 ` Ira Weiny
2021-02-10 12:55 ` Christoph Hellwig
2021-02-10 16:29 ` Ira Weiny
2021-02-10 16:41 ` Christoph Hellwig
2021-02-10 17:04 ` Ira Weiny
2021-02-10 18:56 ` Matthew Wilcox
2021-02-10 21:22 ` Ira Weiny
2021-02-11 18:52 ` David Sterba
2021-02-10 17:49 ` [PATCH V2.1] " ira.weiny
2021-02-10 6:22 ` [PATCH V2 5/8] iov_iter: Remove memzero_page() in favor of zero_user() ira.weiny
2021-02-10 12:55 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 6/8] btrfs: use memcpy_[to|from]_page() and kmap_local_page() ira.weiny
2021-02-10 12:56 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 7/8] btrfs: use copy_highpage() instead of 2 kmaps() ira.weiny
2021-02-10 12:56 ` Christoph Hellwig
2021-02-10 6:22 ` [PATCH V2 8/8] btrfs: convert to zero_user() ira.weiny
2021-02-10 12:57 ` Christoph Hellwig
2021-02-11 19:38 ` David Sterba [this message]
2021-02-11 21:32 ` [PATCH V2 0/8] btrfs: convert kmaps to core page calls Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210211193803.GH1993@suse.cz \
--to=dsterba@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=clm@fb.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=josef@toxicpanda.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).