From: Jan Kara <jack@suse.cz>
To: Chengguang Xu <cgxu519@mykernel.net>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: don't specify flag FIEMAP_FLAG_SYNC when calling fiemap_prep()
Date: Wed, 24 Feb 2021 15:34:42 +0100 [thread overview]
Message-ID: <20210224143442.GA849@quack2.suse.cz> (raw)
In-Reply-To: <20210223131632.2208648-1-cgxu519@mykernel.net>
On Tue 23-02-21 21:16:32, Chengguang Xu wrote:
> commit 45dd052e67ad17c7a ("fs: handle FIEMAP_FLAG_SYNC in fiemap_prep")
> has moved FIEMAP_FLAG_SYNC handling to fiemap_prep(), so don't have
> to specify flags FIEMAP_FLAG_SYNC when calling fiemap_prep in
> __generic_block_fiemap().
>
> Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
Looks good to me. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ioctl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/ioctl.c b/fs/ioctl.c
> index 4e6cc0a7d69c..49355e689750 100644
> --- a/fs/ioctl.c
> +++ b/fs/ioctl.c
> @@ -303,7 +303,7 @@ static int __generic_block_fiemap(struct inode *inode,
> bool past_eof = false, whole_file = false;
> int ret = 0;
>
> - ret = fiemap_prep(inode, fieinfo, start, &len, FIEMAP_FLAG_SYNC);
> + ret = fiemap_prep(inode, fieinfo, start, &len, 0);
> if (ret)
> return ret;
>
> --
> 2.27.0
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2021-02-24 15:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 13:16 [PATCH] fs: don't specify flag FIEMAP_FLAG_SYNC when calling fiemap_prep() Chengguang Xu
2021-02-24 14:34 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210224143442.GA849@quack2.suse.cz \
--to=jack@suse.cz \
--cc=cgxu519@mykernel.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).