* [PATCH] fs: use sb_end_write instend of __sb_end_write
@ 2021-02-19 12:01 Fengnan Chang
2021-02-24 14:40 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Fengnan Chang @ 2021-02-19 12:01 UTC (permalink / raw)
To: viro, linux-fsdevel; +Cc: Fengnan Chang
__sb_end_write is an internal function, use sb_end_write instead of __sb_end_write.
Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
---
include/linux/fs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index fd47deea7c17..6b2e6f9035a5 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2784,7 +2784,7 @@ static inline void file_end_write(struct file *file)
{
if (!S_ISREG(file_inode(file)->i_mode))
return;
- __sb_end_write(file_inode(file)->i_sb, SB_FREEZE_WRITE);
+ sb_end_write(file_inode(file)->i_sb);
}
/*
--
2.29.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs: use sb_end_write instend of __sb_end_write
2021-02-19 12:01 [PATCH] fs: use sb_end_write instend of __sb_end_write Fengnan Chang
@ 2021-02-24 14:40 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2021-02-24 14:40 UTC (permalink / raw)
To: Fengnan Chang; +Cc: viro, linux-fsdevel
On Fri 19-02-21 20:01:49, Fengnan Chang wrote:
> __sb_end_write is an internal function, use sb_end_write instead of __sb_end_write.
>
> Signed-off-by: Fengnan Chang <changfengnan@vivo.com>
Makes sense. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> include/linux/fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index fd47deea7c17..6b2e6f9035a5 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -2784,7 +2784,7 @@ static inline void file_end_write(struct file *file)
> {
> if (!S_ISREG(file_inode(file)->i_mode))
> return;
> - __sb_end_write(file_inode(file)->i_sb, SB_FREEZE_WRITE);
> + sb_end_write(file_inode(file)->i_sb);
> }
>
> /*
> --
> 2.29.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-24 15:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-19 12:01 [PATCH] fs: use sb_end_write instend of __sb_end_write Fengnan Chang
2021-02-24 14:40 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).