* [PATCH] fs: Use WARN(1,...)
@ 2021-02-26 9:49 Xu Wang
0 siblings, 0 replies; 3+ messages in thread
From: Xu Wang @ 2021-02-26 9:49 UTC (permalink / raw)
To: viro, linux-fsdevel; +Cc: linux-kernel
Use WARN(1,...) rather than printk followed by WARN_ON(1).
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
fs/dcache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index 2cdfdcd4276b..1dad7069dfe5 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1637,7 +1637,7 @@ static enum d_walk_ret umount_check(void *_data, struct dentry *dentry)
if (dentry == _data && dentry->d_lockref.count == 1)
return D_WALK_CONTINUE;
- WARN(1, KERN_ERR "BUG: Dentry %p{i=%lx,n=%pd} "
+ WARN(1, "BUG: Dentry %p{i=%lx,n=%pd} "
" still in use (%d) [unmount of %s %s]\n",
dentry,
dentry->d_inode ?
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] fs: Use WARN(1,...)
@ 2021-02-26 9:49 Xu Wang
2021-02-26 12:10 ` Matthew Wilcox
0 siblings, 1 reply; 3+ messages in thread
From: Xu Wang @ 2021-02-26 9:49 UTC (permalink / raw)
To: viro, linux-fsdevel; +Cc: linux-kernel
Use WARN(1,...) rather than printk followed by WARN_ON(1).
Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
---
fs/dcache.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/dcache.c b/fs/dcache.c
index 2cdfdcd4276b..1dad7069dfe5 100644
--- a/fs/dcache.c
+++ b/fs/dcache.c
@@ -1637,7 +1637,7 @@ static enum d_walk_ret umount_check(void *_data, struct dentry *dentry)
if (dentry == _data && dentry->d_lockref.count == 1)
return D_WALK_CONTINUE;
- WARN(1, KERN_ERR "BUG: Dentry %p{i=%lx,n=%pd} "
+ WARN(1, "BUG: Dentry %p{i=%lx,n=%pd} "
" still in use (%d) [unmount of %s %s]\n",
dentry,
dentry->d_inode ?
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: Use WARN(1,...)
2021-02-26 9:49 [PATCH] fs: Use WARN(1,...) Xu Wang
@ 2021-02-26 12:10 ` Matthew Wilcox
0 siblings, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2021-02-26 12:10 UTC (permalink / raw)
To: Xu Wang; +Cc: viro, linux-fsdevel, linux-kernel
On Fri, Feb 26, 2021 at 09:49:49AM +0000, Xu Wang wrote:
> Use WARN(1,...) rather than printk followed by WARN_ON(1).
This description doesn't match the patch.
> - WARN(1, KERN_ERR "BUG: Dentry %p{i=%lx,n=%pd} "
> + WARN(1, "BUG: Dentry %p{i=%lx,n=%pd} "
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-02-26 12:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-26 9:49 [PATCH] fs: Use WARN(1,...) Xu Wang
2021-02-26 12:10 ` Matthew Wilcox
-- strict thread matches above, loose matches on Subject: below --
2021-02-26 9:49 Xu Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).