From: Matthew Wilcox <willy@infradead.org>
To: Zi Yan <ziy@nvidia.com>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Mike Kravetz <mike.kravetz@oracle.com>
Subject: Re: [PATCH v3 01/25] mm: Introduce struct folio
Date: Mon, 1 Mar 2021 20:53:06 +0000 [thread overview]
Message-ID: <20210301205306.GU2723601@casper.infradead.org> (raw)
In-Reply-To: <68723D50-AFD1-4F25-8F10-81EC11045BE5@nvidia.com>
On Mon, Mar 01, 2021 at 03:26:11PM -0500, Zi Yan wrote:
> > +static inline struct folio *next_folio(struct folio *folio)
> > +{
> > + return folio + folio_nr_pages(folio);
>
> Are you planning to make hugetlb use folio too?
Eventually, probably. It's not my focus.
> If yes, this might not work if we have CONFIG_SPARSEMEM && !CONFIG_SPARSEMEM_VMEMMAP
> with a hugetlb folio > MAX_ORDER, because struct page might not be virtually contiguous.
> See the experiment I did in [1].
>
> [1] https://lore.kernel.org/linux-mm/16F7C58B-4D79-41C5-9B64-A1A1628F4AF2@nvidia.com/
I thought we were going to forbid that configuration? ie no pages
larger than MAX_ORDER with (SPARSEMEM && !SPARSEMEM_VMEMMAP)
https://lore.kernel.org/linux-mm/312AECBD-CA6D-4E93-A6C1-1DF87BABD92D@nvidia.com/
is somewhere else we were discussing this.
next prev parent reply other threads:[~2021-03-01 20:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-28 7:03 [PATCH v3 00/25] Page folios Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 01/25] mm: Introduce struct folio Matthew Wilcox (Oracle)
2021-03-01 20:26 ` Zi Yan
2021-03-01 20:53 ` Matthew Wilcox [this message]
2021-03-01 21:03 ` Zi Yan
2021-03-02 13:22 ` Matthew Wilcox
2021-03-02 17:47 ` Zi Yan
2021-01-28 7:03 ` [PATCH v3 02/25] mm: Add folio_pgdat Matthew Wilcox (Oracle)
2021-03-01 21:05 ` Zi Yan
2021-01-28 7:03 ` [PATCH v3 03/25] mm/vmstat: Add folio stat wrappers Matthew Wilcox (Oracle)
2021-03-01 21:17 ` Zi Yan
2021-03-01 22:15 ` Matthew Wilcox
2021-01-28 7:03 ` [PATCH v3 04/25] mm/debug: Add VM_BUG_ON_FOLIO and VM_WARN_ON_ONCE_FOLIO Matthew Wilcox (Oracle)
2021-03-01 21:25 ` Zi Yan
2021-01-28 7:03 ` [PATCH v3 05/25] mm: Add put_folio Matthew Wilcox (Oracle)
2021-03-01 21:41 ` Zi Yan
2021-01-28 7:03 ` [PATCH v3 06/25] mm: Add get_folio Matthew Wilcox (Oracle)
2021-03-01 21:45 ` Zi Yan
2021-01-28 7:03 ` [PATCH v3 07/25] mm: Create FolioFlags Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 08/25] mm: Handle per-folio private data Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 09/25] mm: Add folio_index, folio_page and folio_contains Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 10/25] mm/util: Add folio_mapping and folio_file_mapping Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 11/25] mm/memcg: Add folio_memcg, lock_folio_memcg and unlock_folio_memcg Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 12/25] mm/memcg: Add mem_cgroup_folio_lruvec Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 13/25] mm: Add unlock_folio Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 14/25] mm: Add lock_folio Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 15/25] mm: Add lock_folio_killable Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 16/25] mm: Convert lock_page_async to lock_folio_async Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 17/25] mm/filemap: Convert end_page_writeback to end_folio_writeback Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 18/25] mm: Convert wait_on_page_bit to wait_on_folio_bit Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 19/25] mm: Add wait_for_stable_folio and wait_on_folio_writeback Matthew Wilcox (Oracle)
2021-01-28 7:03 ` [PATCH v3 20/25] mm: Add wait_on_folio_locked & wait_on_folio_locked_killable Matthew Wilcox (Oracle)
2021-01-28 7:04 ` [PATCH v3 21/25] mm: Convert lock_page_or_retry to lock_folio_or_retry Matthew Wilcox (Oracle)
2021-01-28 7:04 ` [PATCH v3 22/25] mm/filemap: Convert wake_up_page_bit to wake_up_folio_bit Matthew Wilcox (Oracle)
2021-01-28 7:04 ` [PATCH v3 23/25] mm: Convert test_clear_page_writeback to test_clear_folio_writeback Matthew Wilcox (Oracle)
2021-01-28 7:04 ` [PATCH v3 24/25] mm/filemap: Convert page wait queues to be folios Matthew Wilcox (Oracle)
2021-01-28 7:04 ` [PATCH v3 25/25] cachefiles: Switch to wait_page_key Matthew Wilcox (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210301205306.GU2723601@casper.infradead.org \
--to=willy@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).