From: Andrew Morton <akpm@linux-foundation.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
Kent Overstreet <kent.overstreet@gmail.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] mm/filemap: Use filemap_read_page in filemap_fault
Date: Tue, 2 Mar 2021 17:30:39 -0800 [thread overview]
Message-ID: <20210302173039.4625f403846abd20413f6dad@linux-foundation.org> (raw)
In-Reply-To: <20210226140011.2883498-1-willy@infradead.org>
On Fri, 26 Feb 2021 14:00:11 +0000 "Matthew Wilcox (Oracle)" <willy@infradead.org> wrote:
> After splitting generic_file_buffered_read() into smaller parts, it
> turns out we can reuse one of the parts in filemap_fault(). This fixes
> an oversight -- waiting for the I/O to complete is now interruptible
> by a fatal signal. And it saves us a few bytes of text in an unlikely
> path.
We also handle AOP_TRUNCATED_PAGE which the present code fails to do.
Should this be in the changelog?
Did we handle AOP_TRUNCATED_PAGE in the pre-splitup code, or is this new?
next prev parent reply other threads:[~2021-03-03 5:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 14:00 [PATCH] mm/filemap: Use filemap_read_page in filemap_fault Matthew Wilcox (Oracle)
2021-03-03 1:30 ` Andrew Morton [this message]
2021-03-03 1:33 ` Matthew Wilcox
2021-03-03 6:07 ` Andrew Morton
2021-03-03 13:26 ` Matthew Wilcox
2021-03-03 20:12 ` Andrew Morton
2021-03-03 20:57 ` Matthew Wilcox
2021-03-03 21:51 ` Andrew Morton
2021-03-03 22:31 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210302173039.4625f403846abd20413f6dad@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=kent.overstreet@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).