From: Christoph Hellwig <hch@infradead.org>
To: Jan Kara <jack@suse.cz>
Cc: "zhangyi (F)" <yi.zhang@huawei.com>,
linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
tytso@mit.edu, viro@zeniv.linux.org.uk
Subject: Re: [PATCH] block_dump: don't put the last refcount when marking inode dirty
Date: Fri, 5 Mar 2021 13:24:42 +0000 [thread overview]
Message-ID: <20210305132442.GA2801131@infradead.org> (raw)
In-Reply-To: <20210301112102.GD25026@quack2.suse.cz>
On Mon, Mar 01, 2021 at 12:21:02PM +0100, Jan Kara wrote:
> Hrm, ok. Honestly, I wanted to just delete that code for a long time. IMO
> tracepoints (and we have one in __mark_inode_dirty) are much more useful
> for tracing anyway. This code exists only because it was there much before
> tracepoints existed... Do you have a strong reason why are you using
> block_dump instead of tracepoint trace_writeback_mark_inode_dirty() for
> your monitoring?
Let me play devils advocate here, the downside of the writeback
tracepoints is that they only trace the inode number and not a file name
(component). Which is also the reason they avoid this problem.
That being said block_dump is a horrible hack, and trace points are the
proper replacement.
prev parent reply other threads:[~2021-03-05 13:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 10:31 [PATCH] block_dump: don't put the last refcount when marking inode dirty zhangyi (F)
2021-03-01 11:21 ` Jan Kara
2021-03-04 13:37 ` zhangyi (F)
2021-03-05 10:10 ` Jan Kara
2021-03-05 12:01 ` zhangyi (F)
2021-03-05 13:24 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210305132442.GA2801131@infradead.org \
--to=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).