From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18CB6C433E0 for ; Thu, 11 Mar 2021 08:42:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 985DA64FA3 for ; Thu, 11 Mar 2021 08:42:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231614AbhCKImv (ORCPT ); Thu, 11 Mar 2021 03:42:51 -0500 Received: from verein.lst.de ([213.95.11.211]:39923 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231147AbhCKImV (ORCPT ); Thu, 11 Mar 2021 03:42:21 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id E7A7968B05; Thu, 11 Mar 2021 09:42:17 +0100 (CET) Date: Thu, 11 Mar 2021 09:42:17 +0100 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , Andrew Morton , Daniel Vetter , Nadav Amit , "VMware, Inc." , "Michael S. Tsirkin" , David Hildenbrand , Minchan Kim , Nitin Gupta , Jason Gunthorpe , Alex Williamson , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/9] powerpc/pseries: remove the ppc-cmm file system Message-ID: <20210311084217.GB7263@lst.de> References: <20210309155348.974875-1-hch@lst.de> <20210309155348.974875-4-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Mar 10, 2021 at 04:29:51PM +0000, Al Viro wrote: > On Tue, Mar 09, 2021 at 04:53:42PM +0100, Christoph Hellwig wrote: > > Just use the generic anon_inode file system. > > Umm... The only problem I see here is the lifetime rules for > that module, and that's not something introduced in this patchset. > Said that, looks like the logics around that place is duplicated in > cmm.c, vmw_balloon.c and virtion_balloon.c and I wonder if it would > be better off with a helper in mm/balloon.c to be used for that setup... Independ of all other discussions untangling that mess does seem very useful.