* [PATCH v2] virtiofs: fix memory leak in virtio_fs_probe()
@ 2021-03-17 8:44 Luis Henriques
2021-03-17 9:36 ` Stefan Hajnoczi
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Luis Henriques @ 2021-03-17 8:44 UTC (permalink / raw)
To: Vivek Goyal, Stefan Hajnoczi, Miklos Szeredi
Cc: virtualization, linux-fsdevel, linux-kernel, virtio-fs,
Luis Henriques, stable
When accidentally passing twice the same tag to qemu, kmemleak ended up
reporting a memory leak in virtiofs. Also, looking at the log I saw the
following error (that's when I realised the duplicated tag):
virtiofs: probe of virtio5 failed with error -17
Here's the kmemleak log for reference:
unreferenced object 0xffff888103d47800 (size 1024):
comm "systemd-udevd", pid 118, jiffies 4294893780 (age 18.340s)
hex dump (first 32 bytes):
00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N..........
ff ff ff ff ff ff ff ff 80 90 02 a0 ff ff ff ff ................
backtrace:
[<000000000ebb87c1>] virtio_fs_probe+0x171/0x7ae [virtiofs]
[<00000000f8aca419>] virtio_dev_probe+0x15f/0x210
[<000000004d6baf3c>] really_probe+0xea/0x430
[<00000000a6ceeac8>] device_driver_attach+0xa8/0xb0
[<00000000196f47a7>] __driver_attach+0x98/0x140
[<000000000b20601d>] bus_for_each_dev+0x7b/0xc0
[<00000000399c7b7f>] bus_add_driver+0x11b/0x1f0
[<0000000032b09ba7>] driver_register+0x8f/0xe0
[<00000000cdd55998>] 0xffffffffa002c013
[<000000000ea196a2>] do_one_initcall+0x64/0x2e0
[<0000000008f727ce>] do_init_module+0x5c/0x260
[<000000003cdedab6>] __do_sys_finit_module+0xb5/0x120
[<00000000ad2f48c6>] do_syscall_64+0x33/0x40
[<00000000809526b5>] entry_SYSCALL_64_after_hwframe+0x44/0xae
Cc: stable@vger.kernel.org
Signed-off-by: Luis Henriques <lhenriques@suse.de>
---
Changes since v1:
- Use kfree() to free fs->vqs instead of calling virtio_fs_put()
fs/fuse/virtio_fs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
index 8868ac31a3c0..989ef4f88636 100644
--- a/fs/fuse/virtio_fs.c
+++ b/fs/fuse/virtio_fs.c
@@ -896,6 +896,7 @@ static int virtio_fs_probe(struct virtio_device *vdev)
out_vqs:
vdev->config->reset(vdev);
virtio_fs_cleanup_vqs(vdev, fs);
+ kfree(fs->vqs);
out:
vdev->priv = NULL;
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] virtiofs: fix memory leak in virtio_fs_probe()
2021-03-17 8:44 [PATCH v2] virtiofs: fix memory leak in virtio_fs_probe() Luis Henriques
@ 2021-03-17 9:36 ` Stefan Hajnoczi
2021-03-17 12:31 ` Vivek Goyal
2021-04-12 15:16 ` Miklos Szeredi
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2021-03-17 9:36 UTC (permalink / raw)
To: Luis Henriques
Cc: Vivek Goyal, Miklos Szeredi, virtualization, linux-fsdevel,
linux-kernel, virtio-fs, stable
[-- Attachment #1: Type: text/plain, Size: 1805 bytes --]
On Wed, Mar 17, 2021 at 08:44:43AM +0000, Luis Henriques wrote:
> When accidentally passing twice the same tag to qemu, kmemleak ended up
> reporting a memory leak in virtiofs. Also, looking at the log I saw the
> following error (that's when I realised the duplicated tag):
>
> virtiofs: probe of virtio5 failed with error -17
>
> Here's the kmemleak log for reference:
>
> unreferenced object 0xffff888103d47800 (size 1024):
> comm "systemd-udevd", pid 118, jiffies 4294893780 (age 18.340s)
> hex dump (first 32 bytes):
> 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N..........
> ff ff ff ff ff ff ff ff 80 90 02 a0 ff ff ff ff ................
> backtrace:
> [<000000000ebb87c1>] virtio_fs_probe+0x171/0x7ae [virtiofs]
> [<00000000f8aca419>] virtio_dev_probe+0x15f/0x210
> [<000000004d6baf3c>] really_probe+0xea/0x430
> [<00000000a6ceeac8>] device_driver_attach+0xa8/0xb0
> [<00000000196f47a7>] __driver_attach+0x98/0x140
> [<000000000b20601d>] bus_for_each_dev+0x7b/0xc0
> [<00000000399c7b7f>] bus_add_driver+0x11b/0x1f0
> [<0000000032b09ba7>] driver_register+0x8f/0xe0
> [<00000000cdd55998>] 0xffffffffa002c013
> [<000000000ea196a2>] do_one_initcall+0x64/0x2e0
> [<0000000008f727ce>] do_init_module+0x5c/0x260
> [<000000003cdedab6>] __do_sys_finit_module+0xb5/0x120
> [<00000000ad2f48c6>] do_syscall_64+0x33/0x40
> [<00000000809526b5>] entry_SYSCALL_64_after_hwframe+0x44/0xae
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Luis Henriques <lhenriques@suse.de>
> ---
> Changes since v1:
> - Use kfree() to free fs->vqs instead of calling virtio_fs_put()
>
> fs/fuse/virtio_fs.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] virtiofs: fix memory leak in virtio_fs_probe()
2021-03-17 8:44 [PATCH v2] virtiofs: fix memory leak in virtio_fs_probe() Luis Henriques
2021-03-17 9:36 ` Stefan Hajnoczi
@ 2021-03-17 12:31 ` Vivek Goyal
2021-04-12 15:16 ` Miklos Szeredi
2 siblings, 0 replies; 4+ messages in thread
From: Vivek Goyal @ 2021-03-17 12:31 UTC (permalink / raw)
To: Luis Henriques
Cc: Stefan Hajnoczi, Miklos Szeredi, virtualization, linux-fsdevel,
linux-kernel, virtio-fs, stable
On Wed, Mar 17, 2021 at 08:44:43AM +0000, Luis Henriques wrote:
> When accidentally passing twice the same tag to qemu, kmemleak ended up
> reporting a memory leak in virtiofs. Also, looking at the log I saw the
> following error (that's when I realised the duplicated tag):
>
> virtiofs: probe of virtio5 failed with error -17
>
> Here's the kmemleak log for reference:
>
> unreferenced object 0xffff888103d47800 (size 1024):
> comm "systemd-udevd", pid 118, jiffies 4294893780 (age 18.340s)
> hex dump (first 32 bytes):
> 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N..........
> ff ff ff ff ff ff ff ff 80 90 02 a0 ff ff ff ff ................
> backtrace:
> [<000000000ebb87c1>] virtio_fs_probe+0x171/0x7ae [virtiofs]
> [<00000000f8aca419>] virtio_dev_probe+0x15f/0x210
> [<000000004d6baf3c>] really_probe+0xea/0x430
> [<00000000a6ceeac8>] device_driver_attach+0xa8/0xb0
> [<00000000196f47a7>] __driver_attach+0x98/0x140
> [<000000000b20601d>] bus_for_each_dev+0x7b/0xc0
> [<00000000399c7b7f>] bus_add_driver+0x11b/0x1f0
> [<0000000032b09ba7>] driver_register+0x8f/0xe0
> [<00000000cdd55998>] 0xffffffffa002c013
> [<000000000ea196a2>] do_one_initcall+0x64/0x2e0
> [<0000000008f727ce>] do_init_module+0x5c/0x260
> [<000000003cdedab6>] __do_sys_finit_module+0xb5/0x120
> [<00000000ad2f48c6>] do_syscall_64+0x33/0x40
> [<00000000809526b5>] entry_SYSCALL_64_after_hwframe+0x44/0xae
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Luis Henriques <lhenriques@suse.de>
Reviewed-by: Vivek Goyal <vgoyal@redhat.com>
Thanks
Vivek
> ---
> Changes since v1:
> - Use kfree() to free fs->vqs instead of calling virtio_fs_put()
>
> fs/fuse/virtio_fs.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/fs/fuse/virtio_fs.c b/fs/fuse/virtio_fs.c
> index 8868ac31a3c0..989ef4f88636 100644
> --- a/fs/fuse/virtio_fs.c
> +++ b/fs/fuse/virtio_fs.c
> @@ -896,6 +896,7 @@ static int virtio_fs_probe(struct virtio_device *vdev)
> out_vqs:
> vdev->config->reset(vdev);
> virtio_fs_cleanup_vqs(vdev, fs);
> + kfree(fs->vqs);
>
> out:
> vdev->priv = NULL;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] virtiofs: fix memory leak in virtio_fs_probe()
2021-03-17 8:44 [PATCH v2] virtiofs: fix memory leak in virtio_fs_probe() Luis Henriques
2021-03-17 9:36 ` Stefan Hajnoczi
2021-03-17 12:31 ` Vivek Goyal
@ 2021-04-12 15:16 ` Miklos Szeredi
2 siblings, 0 replies; 4+ messages in thread
From: Miklos Szeredi @ 2021-04-12 15:16 UTC (permalink / raw)
To: Luis Henriques
Cc: Vivek Goyal, Stefan Hajnoczi, virtualization, linux-fsdevel,
linux-kernel, virtio-fs-list, stable
On Wed, Mar 17, 2021 at 9:43 AM Luis Henriques <lhenriques@suse.de> wrote:
>
> When accidentally passing twice the same tag to qemu, kmemleak ended up
> reporting a memory leak in virtiofs. Also, looking at the log I saw the
> following error (that's when I realised the duplicated tag):
>
> virtiofs: probe of virtio5 failed with error -17
>
> Here's the kmemleak log for reference:
>
> unreferenced object 0xffff888103d47800 (size 1024):
> comm "systemd-udevd", pid 118, jiffies 4294893780 (age 18.340s)
> hex dump (first 32 bytes):
> 00 00 00 00 ad 4e ad de ff ff ff ff 00 00 00 00 .....N..........
> ff ff ff ff ff ff ff ff 80 90 02 a0 ff ff ff ff ................
> backtrace:
> [<000000000ebb87c1>] virtio_fs_probe+0x171/0x7ae [virtiofs]
> [<00000000f8aca419>] virtio_dev_probe+0x15f/0x210
> [<000000004d6baf3c>] really_probe+0xea/0x430
> [<00000000a6ceeac8>] device_driver_attach+0xa8/0xb0
> [<00000000196f47a7>] __driver_attach+0x98/0x140
> [<000000000b20601d>] bus_for_each_dev+0x7b/0xc0
> [<00000000399c7b7f>] bus_add_driver+0x11b/0x1f0
> [<0000000032b09ba7>] driver_register+0x8f/0xe0
> [<00000000cdd55998>] 0xffffffffa002c013
> [<000000000ea196a2>] do_one_initcall+0x64/0x2e0
> [<0000000008f727ce>] do_init_module+0x5c/0x260
> [<000000003cdedab6>] __do_sys_finit_module+0xb5/0x120
> [<00000000ad2f48c6>] do_syscall_64+0x33/0x40
> [<00000000809526b5>] entry_SYSCALL_64_after_hwframe+0x44/0xae
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Luis Henriques <lhenriques@suse.de>
> ---
> Changes since v1:
> - Use kfree() to free fs->vqs instead of calling virtio_fs_put()
Applied, thanks.
Miklos
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-12 15:16 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-17 8:44 [PATCH v2] virtiofs: fix memory leak in virtio_fs_probe() Luis Henriques
2021-03-17 9:36 ` Stefan Hajnoczi
2021-03-17 12:31 ` Vivek Goyal
2021-04-12 15:16 ` Miklos Szeredi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).