From: Christoph Hellwig <hch@lst.de>
To: Christian Brauner <christian.brauner@ubuntu.com>
Cc: Christoph Hellwig <hch@lst.de>, Al Viro <viro@zeniv.linux.org.uk>,
Vivek Goyal <vgoyal@redhat.com>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] fs: improve naming for fsid helpers
Date: Thu, 18 Mar 2021 07:27:23 +0100 [thread overview]
Message-ID: <20210318062723.GB29726@lst.de> (raw)
In-Reply-To: <20210315145419.2612537-3-christian.brauner@ubuntu.com>
> -static inline kuid_t fsuid_into_mnt(struct user_namespace *mnt_userns)
> +static inline kuid_t idmapped_fsuid(struct user_namespace *mnt_userns)
> {
> return kuid_from_mnt(mnt_userns, current_fsuid());
> }
>
> -static inline kgid_t fsgid_into_mnt(struct user_namespace *mnt_userns)
> +static inline kgid_t idmapped_fsgid(struct user_namespace *mnt_userns)
> {
> return kgid_from_mnt(mnt_userns, current_fsgid());
> }
I'm not sure the naming is an improvement. I always think of
identity mapped when reading it, which couldn't be further from what
it does.. But either way comments describing what these helpers do
would be very useful.
next prev parent reply other threads:[~2021-03-18 6:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-15 14:54 [PATCH 0/3] tweak idmap helpers Christian Brauner
2021-03-15 14:54 ` [PATCH 1/3] fs: introduce fsuidgid_has_mapping() helper Christian Brauner
2021-03-18 6:26 ` Christoph Hellwig
2021-03-15 14:54 ` [PATCH 2/3] fs: improve naming for fsid helpers Christian Brauner
2021-03-18 6:27 ` Christoph Hellwig [this message]
2021-03-18 6:30 ` Al Viro
2021-03-18 11:40 ` Christian Brauner
2021-03-18 11:40 ` Christian Brauner
2021-03-15 14:54 ` [PATCH 3/3] fs: introduce two little fs{u,g}id inode initialization helpers Christian Brauner
2021-03-18 6:27 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210318062723.GB29726@lst.de \
--to=hch@lst.de \
--cc=christian.brauner@ubuntu.com \
--cc=djwong@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=vgoyal@redhat.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).