From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB003C433DB for ; Thu, 18 Mar 2021 06:28:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 65A6064F2A for ; Thu, 18 Mar 2021 06:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229735AbhCRG15 (ORCPT ); Thu, 18 Mar 2021 02:27:57 -0400 Received: from verein.lst.de ([213.95.11.211]:40240 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229784AbhCRG1r (ORCPT ); Thu, 18 Mar 2021 02:27:47 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 33B9868C65; Thu, 18 Mar 2021 07:27:46 +0100 (CET) Date: Thu, 18 Mar 2021 07:27:45 +0100 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , Al Viro , Vivek Goyal , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH 3/3] fs: introduce two little fs{u,g}id inode initialization helpers Message-ID: <20210318062745.GC29726@lst.de> References: <20210315145419.2612537-1-christian.brauner@ubuntu.com> <20210315145419.2612537-4-christian.brauner@ubuntu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210315145419.2612537-4-christian.brauner@ubuntu.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, Mar 15, 2021 at 03:54:19PM +0100, Christian Brauner wrote: > Give filesystem two little helpers so that do the right thing when > initializing the i_uid and i_gid fields on idmapped and non-idmapped > mounts. Filesystemd don't need to bother with too many details for this. Looks good, Reviewed-by: Christoph Hellwig