From: Matthew Wilcox <willy@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Mike Marshall <hubcap@omnibond.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [RFC PATCH v2] implement orangefs_readahead
Date: Sat, 27 Mar 2021 13:56:59 +0000 [thread overview]
Message-ID: <20210327135659.GH1719932@casper.infradead.org> (raw)
In-Reply-To: <1507388.1616833898@warthog.procyon.org.uk>
On Sat, Mar 27, 2021 at 08:31:38AM +0000, David Howells wrote:
> However, in Mike's orangefs_readahead_cleanup(), he could replace:
>
> rcu_read_lock();
> xas_for_each(&xas, page, last) {
> page_endio(page, false, 0);
> put_page(page);
> }
> rcu_read_unlock();
>
> with:
>
> while ((page = readahead_page(ractl))) {
> page_endio(page, false, 0);
> put_page(page);
> }
>
> maybe?
I'd rather see that than open-coded use of the XArray. It's mildly
slower, but given that we're talking about doing I/O, probably not enough
to care about.
next prev parent reply other threads:[~2021-03-27 14:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 22:25 [RFC PATCH] implement orangefs_readahead Mike Marshall
2021-02-01 13:08 ` Matthew Wilcox
2021-02-02 3:32 ` Mike Marshall
2021-03-13 15:31 ` [RFC PATCH v2] " Mike Marshall
2021-03-17 3:04 ` Mike Marshall
2021-03-24 11:10 ` David Howells
2021-03-27 2:55 ` Mike Marshall
2021-03-27 3:50 ` Matthew Wilcox
2021-03-27 8:31 ` David Howells
2021-03-27 13:56 ` Matthew Wilcox [this message]
2021-03-27 15:40 ` Mike Marshall
2021-03-27 15:56 ` Matthew Wilcox
2021-03-28 3:04 ` Mike Marshall
2021-03-29 1:51 ` Mike Marshall
2021-03-29 9:37 ` David Howells
2021-03-29 23:25 ` Mike Marshall
[not found] ` <3726695.1617284551@warthog.procyon.org.uk >
2021-04-13 15:08 ` David Howells
2021-04-16 14:36 ` Mike Marshall
2021-04-16 15:14 ` Matthew Wilcox
2021-04-25 1:51 ` Mike Marshall
2021-04-16 15:41 ` David Howells
2021-04-25 1:43 ` Mike Marshall
2021-04-25 7:49 ` David Howells
2021-04-26 14:53 ` Mike Marshall
2021-04-26 19:01 ` Mike Marshall
2021-04-26 20:01 ` David Howells
2021-04-26 8:37 ` David Howells
2021-04-01 13:42 ` David Howells
2021-04-08 20:39 ` Mike Marshall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210327135659.GH1719932@casper.infradead.org \
--to=willy@infradead.org \
--cc=dhowells@redhat.com \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).