From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E8E6C433ED for ; Tue, 6 Apr 2021 14:18:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 13050613A9 for ; Tue, 6 Apr 2021 14:18:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345010AbhDFOSe (ORCPT ); Tue, 6 Apr 2021 10:18:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41010 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232541AbhDFOSb (ORCPT ); Tue, 6 Apr 2021 10:18:31 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15355C06174A; Tue, 6 Apr 2021 07:18:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=J9Nv9IOG0QNz+4Jv7FRoXmiGuQ+az6VOieXESJEb6Gc=; b=lpA0f+RC9KFdg7gwzg1NeRmt4f NnjKmrT1rw6REyi1y2TOVazUZMB3s4wewOQaNexk0AhghRi81bkJtxKAf6b6GxRuD+GCuz6FgvK0u qEAJIzza+WRux4qaboZz73duL8MJVcPZQzSx8EICv+6Dx53o8E++9kFK5O9kGv5DpJfhHZWYYNq5U kTQpg48evIogBV+Ni1KMzz/sDUkbb5v/zYLMQqh79BOVHX+O9HnSf5qH8xLIlvzk/+9Ax8Nhx1+eX qi23hl2F2Rl6OurK4Vy1eba8MPSbuJZtrhrFbg6/BP3B4XpMtwm05WKslP8syIqssjCSkg11vCJih cOCzsFBg==; Received: from hch by casper.infradead.org with local (Exim 4.94 #2 (Red Hat Linux)) id 1lTmUT-00Cv9U-5L; Tue, 06 Apr 2021 14:16:05 +0000 Date: Tue, 6 Apr 2021 15:15:37 +0100 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, linux-afs@lists.infradead.org Subject: Re: [PATCH v6 23/27] mm/writeback: Add wait_on_folio_writeback Message-ID: <20210406141537.GV3062550@infradead.org> References: <20210331184728.1188084-1-willy@infradead.org> <20210331184728.1188084-24-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210331184728.1188084-24-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by casper.infradead.org. See http://www.infradead.org/rpr.html Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Mar 31, 2021 at 07:47:24PM +0100, Matthew Wilcox (Oracle) wrote: > wait_on_page_writeback_killable() only has one caller, so convert it to > call wait_on_folio_writeback_killable(). For the wait_on_page_writeback() > callers, add a compatibility wrapper around wait_on_folio_writeback(). > > Turning PageWriteback() into FolioWriteback() eliminates a call to > compound_head() which saves 8 bytes and 15 bytes in the two functions. > That is more than offset by adding the wait_on_page_writeback > compatibility wrapper for a net increase in text of 15 bytes. Looks good, Reviewed-by: Christoph Hellwig