From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Peter Zijlstra <peterz@infradead.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <keescook@chromium.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Greg Ungerer <gerg@linux-m68k.org>,
Mike Rapoport <rppt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Kevin Brodsky <Kevin.Brodsky@arm.com>,
Michal Hocko <mhocko@suse.com>, Feng Tang <feng.tang@intel.com>,
Don Zickus <dzickus@redhat.com>,
x86@kernel.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH v1 1/3] perf: MAP_EXECUTABLE does not indicate VM_MAYEXEC
Date: Wed, 21 Apr 2021 11:34:51 +0200 [thread overview]
Message-ID: <20210421093453.6904-2-david@redhat.com> (raw)
In-Reply-To: <20210421093453.6904-1-david@redhat.com>
Before commit e9714acf8c43 ("mm: kill vma flag VM_EXECUTABLE and
mm->num_exe_file_vmas"), VM_EXECUTABLE indicated MAP_EXECUTABLE.
MAP_EXECUTABLE is nowadays essentially ignored by the kernel and does
not relate to VM_MAYEXEC.
Fixes: f972eb63b100 ("perf: Pass protection and flags bits through mmap2 interface")
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
kernel/events/core.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/events/core.c b/kernel/events/core.c
index 03db40f6cba9..3dfd463f1831 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -8186,8 +8186,6 @@ static void perf_event_mmap_event(struct perf_mmap_event *mmap_event)
if (vma->vm_flags & VM_DENYWRITE)
flags |= MAP_DENYWRITE;
- if (vma->vm_flags & VM_MAYEXEC)
- flags |= MAP_EXECUTABLE;
if (vma->vm_flags & VM_LOCKED)
flags |= MAP_LOCKED;
if (is_vm_hugetlb_page(vma))
--
2.30.2
next prev parent reply other threads:[~2021-04-21 9:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 9:34 [PATCH v1 0/3] perf/binfmt/mm: remove in-tree usage of MAP_EXECUTABLE David Hildenbrand
2021-04-21 9:34 ` David Hildenbrand [this message]
2021-04-21 9:34 ` [PATCH v1 2/3] binfmt: " David Hildenbrand
2021-05-12 13:12 ` David Hildenbrand
2021-04-21 9:34 ` [PATCH v1 3/3] mm: ignore MAP_EXECUTABLE in ksys_mmap_pgoff() David Hildenbrand
2021-04-21 19:03 ` [PATCH v1 0/3] perf/binfmt/mm: remove in-tree usage of MAP_EXECUTABLE Eric W. Biederman
2021-04-21 19:21 ` Kees Cook
2021-04-21 20:56 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421093453.6904-2-david@redhat.com \
--to=david@redhat.com \
--cc=Kevin.Brodsky@arm.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dzickus@redhat.com \
--cc=ebiederm@xmission.com \
--cc=feng.tang@intel.com \
--cc=gerg@linux-m68k.org \
--cc=hpa@zytor.com \
--cc=jolsa@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rppt@kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).