From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CC025C433B4
	for <linux-fsdevel@archiver.kernel.org>; Fri, 23 Apr 2021 19:29:42 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 995466144A
	for <linux-fsdevel@archiver.kernel.org>; Fri, 23 Apr 2021 19:29:42 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232212AbhDWTaS (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Fri, 23 Apr 2021 15:30:18 -0400
Received: from mail.kernel.org ([198.145.29.99]:56902 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229549AbhDWTaR (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 23 Apr 2021 15:30:17 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id B7E7F61425;
        Fri, 23 Apr 2021 19:29:40 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org;
        s=korg; t=1619206181;
        bh=hmXgOMfwOqJWu9RVsEL53nURi7NTe6eTVDA00J2JLGY=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=ghs6938sRT3RY96brYK9XC67wcNBnu5gflBqZKXhDOXIpujK/eN2ORs7mZ5d0cguv
         K/jbAImScii8I8CnZTmYjJPnnLMZOrLm5GK3V1w5q7qGV2ZtCEJQA6iL9AasAKxH0R
         VE0qhRHkPJIoxR4VbrvpEWBDikog8gNYrPI8DCiY=
Date:   Fri, 23 Apr 2021 12:29:40 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Hugh Dickins <hughd@google.com>
Cc:     Matthew Wilcox <willy@infradead.org>,
        William Kucharski <william.kucharski@oracle.com>,
        Christoph Hellwig <hch@lst.de>, Jan Kara <jack@suse.cz>,
        Dave Chinner <dchinner@redhat.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Yang Shi <yang.shi@linux.alibaba.com>,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-mm@kvack.org
Subject: Re: [PATCH v2 2/2] mm/filemap: fix mapping_seek_hole_data on THP &
 32-bit
Message-Id: <20210423122940.26829dc784a4b6546349dac5@linux-foundation.org>
In-Reply-To: <alpine.LSU.2.11.2104231009520.18646@eggly.anvils>
References: <alpine.LSU.2.11.2104211723580.3299@eggly.anvils>
        <alpine.LSU.2.11.2104211737410.3299@eggly.anvils>
        <20210422011631.GL3596236@casper.infradead.org>
        <alpine.LSU.2.11.2104212253000.4412@eggly.anvils>
        <alpine.LSU.2.11.2104221338410.1170@eggly.anvils>
        <alpine.LSU.2.11.2104221347240.1170@eggly.anvils>
        <20210422160410.e9014b38b843d7a6ec06a9bb@linux-foundation.org>
        <alpine.LSU.2.11.2104231009520.18646@eggly.anvils>
X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

On Fri, 23 Apr 2021 10:22:51 -0700 (PDT) Hugh Dickins <hughd@google.com> wrote:

> On Thu, 22 Apr 2021, Andrew Morton wrote:
> > On Thu, 22 Apr 2021 13:48:57 -0700 (PDT) Hugh Dickins <hughd@google.com> wrote:
> > 
> > > Andrew, I'd have just sent a -fix.patch to remove the unnecessary u64s,
> > > but need to reword the commit message: so please replace yesterday's
> > > mm-filemap-fix-mapping_seek_hole_data-on-thp-32-bit.patch
> > > by this one - thanks.
> > 
> > Actually, I routinely update the base patch's changelog when queueing a -fix.
> 
> And thank you for that, but if there's time, I think we would still
> prefer the final commit message to include corrections where Matthew
> enlightened me (that "sign-extension" claim came from my confusion):

That's my point.  When I merge a -v2 as a -fix, I replace the v1
patch's changelog with v2's changelog so everything works out after
folding.