From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8AD8BC433ED for ; Wed, 28 Apr 2021 20:40:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F2EB61445 for ; Wed, 28 Apr 2021 20:40:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242034AbhD1UlW (ORCPT ); Wed, 28 Apr 2021 16:41:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231953AbhD1UlV (ORCPT ); Wed, 28 Apr 2021 16:41:21 -0400 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5202AC06138A; Wed, 28 Apr 2021 13:40:36 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id 42906727A; Wed, 28 Apr 2021 16:40:35 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org 42906727A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1619642435; bh=N+oITBmKkEW76qibm4RYpln6VObBvQpenPBFkPLgScc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=q7OLm28cyGPOFFcEVvS7P0NTGkDIi2gK9yzVpGOnBBugiUmFmQbaOx8QiWkmhDupj gaQvPwrCBbbiboET6JlfONlAtRVJT4l7gl06GVBqjT3LLyKdVLddpsZ4hSPgRUGyMy TyX+aFsW5Gr53j/gJnBZXoXhKtHBj9j/KYoEh14M= Date: Wed, 28 Apr 2021 16:40:35 -0400 From: "J. Bruce Fields" To: =?utf-8?B?QXVyw6lsaWVu?= Aptel Cc: Namjae Jeon , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, smfrench@gmail.com, senozhatsky@chromium.org, hyc.lee@gmail.com, viro@zeniv.linux.org.uk, hch@lst.de, hch@infradead.org, ronniesahlberg@gmail.com, aurelien.aptel@gmail.com, sandeen@sandeen.net, dan.carpenter@oracle.com, colin.king@canonical.com, rdunlap@infradead.org, willy@infradead.org Subject: Re: [PATCH v2 00/10] cifsd: introduce new SMB3 kernel server Message-ID: <20210428204035.GD7400@fieldses.org> References: <20210422002824.12677-1-namjae.jeon@samsung.com> <20210428191829.GB7400@fieldses.org> <878s52w49d.fsf@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <878s52w49d.fsf@suse.com> User-Agent: Mutt/1.5.21 (2010-09-15) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Apr 28, 2021 at 10:19:58PM +0200, Aurélien Aptel wrote: > bfields@fieldses.org (J. Bruce Fields) writes: > > On Thu, Apr 22, 2021 at 09:28:14AM +0900, Namjae Jeon wrote: > >> This is the patch series for cifsd(ksmbd) kernel server. > > > > Looks like this series probably isn't bisectable. E.g. while looking at > > the ACL code I noticed ksmbd_vfs_setxattr is defined in a later patch > > than it's first used in. > > The Kconfig and Makefile are added in the last patch so it should be ok. I'm not sure if doing that way is really any better than making it one big patch. I'd rather see multiple patches that were actually functional at each stage: e.g., start with a server that responds to some sort of rpc-level ping but does nothing else, then add basic file IO, etc. I don't know if that's practical. --b.