From: Pavel Skripkin <paskripkin@gmail.com>
To: Aviral Gupta <shiv14112001@gmail.com>
Cc: viro@zeniv.linux.org.uk, shuah@kernal.org,
linux-fsdevel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] This commit fixes the error generated due to the wrong indentation which does not follow the codding style norms set by Linux-kernel and space- bar is used in place of tab to give space which causes a visual error for some compilers
Date: Fri, 21 May 2021 14:41:28 +0300 [thread overview]
Message-ID: <20210521144128.052e3c48@gmail.com> (raw)
In-Reply-To: <20210521105654.4046-1-shiv14112001@gmail.com>
On Fri, 21 May 2021 16:26:54 +0530
Aviral Gupta <shiv14112001@gmail.com> wrote:
> ERROR: switch and case should be at the same indent
> + switch (whence) {
> + case 1:
> [...]
> + case 0:
> [...]
> + default:
> ERROR: code indent should use tabs where possible
> + void (*callback)(struct dentry *))$
>
> Signed-off-by: Aviral Gupta <shiv14112001@gmail.com>
> ---
> fs/libfs.c | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
Hi, Aviral!
Always check your patches with ./scripts/checpatch.pl. It will warn You
if your patch has common errors (ex: too long subject line like yours).
I think, this link might be helpful
https://www.kernel.org/doc/html/latest/process/submitting-patches.html.
This document contains canonical patch format and other useful
info about "how to send patches".
Goog luck!
With regards,
Pavel Skripkin
prev parent reply other threads:[~2021-05-21 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-21 10:56 [PATCH] This commit fixes the error generated due to the wrong indentation which does not follow the codding style norms set by Linux-kernel and space- bar is used in place of tab to give space which causes a visual error for some compilers Aviral Gupta
2021-05-21 11:07 ` Greg KH
2021-05-21 11:41 ` Pavel Skripkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210521144128.052e3c48@gmail.com \
--to=paskripkin@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shiv14112001@gmail.com \
--cc=shuah@kernal.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).