From: "Darrick J. Wong" <djwong@kernel.org>
To: Kent Overstreet <kent.overstreet@gmail.com>
Cc: fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-bcachefs@vger.kernel.org
Subject: Re: [PATCH v2 4/4] generic/269: add _check_scratch_fs
Date: Tue, 25 May 2021 18:34:18 -0700 [thread overview]
Message-ID: <20210526013418.GK202095@locust> (raw)
In-Reply-To: <20210525221955.265524-8-kent.overstreet@gmail.com>
On Tue, May 25, 2021 at 06:19:55PM -0400, Kent Overstreet wrote:
> This probably should be in every test that uses the scratch device.
Um, it is -- ./check runs fsck on the test and scratch devices if you
_require_test or _require_scratch'd them (which this test does). What
weird output did you see?
--D
> Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
> ---
> tests/generic/269 | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/generic/269 b/tests/generic/269
> index aec573c06a..484a26f89f 100755
> --- a/tests/generic/269
> +++ b/tests/generic/269
> @@ -63,5 +63,7 @@ if ! _scratch_unmount; then
> status=1
> exit
> fi
> +
> +_check_scratch_fs
> status=0
> exit
> --
> 2.32.0.rc0
>
next prev parent reply other threads:[~2021-05-26 1:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 22:19 [PATCH 1/4] Improved .gitignore Kent Overstreet
2021-05-25 22:19 ` [PATCH 2/4] Initial bcachefs support Kent Overstreet
2021-05-25 22:19 ` [PATCH 3/4] generic/{455,457,482}: make dmlogwrites tests work on bcachefs Kent Overstreet
2021-05-25 22:19 ` [PATCH 4/4] generic/269: add _check_scratch_fs Kent Overstreet
2021-05-25 22:19 ` [PATCH v2 1/4] Improved .gitignore Kent Overstreet
2021-05-25 22:19 ` [PATCH v2 2/4] Initial bcachefs support Kent Overstreet
2021-05-25 22:19 ` [PATCH v2 3/4] generic/{455,457,482}: make dmlogwrites tests work on bcachefs Kent Overstreet
2021-05-30 13:18 ` Eryu Guan
2021-06-01 18:50 ` Kent Overstreet
2021-05-25 22:19 ` [PATCH v2 4/4] generic/269: add _check_scratch_fs Kent Overstreet
2021-05-26 1:34 ` Darrick J. Wong [this message]
2021-05-26 1:53 ` Kent Overstreet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526013418.GK202095@locust \
--to=djwong@kernel.org \
--cc=fstests@vger.kernel.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-bcachefs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox