From: Jan Kara <jack@suse.cz>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Amir Goldstein <amir73il@gmail.com>, Jan Kara <jack@suse.cz>,
Matthew Bobrowski <mbobrowski@mbobrowski.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH][v2] fanotify: fix permission model of unprivileged group
Date: Tue, 8 Jun 2021 14:28:29 +0200 [thread overview]
Message-ID: <20210608122829.GI5562@quack2.suse.cz> (raw)
In-Reply-To: <YL9gzn71T82YOdbF@kroah.com>
On Tue 08-06-21 14:21:34, Greg KH wrote:
> On Mon, May 24, 2021 at 04:53:21PM +0300, Amir Goldstein wrote:
> > Reporting event->pid should depend on the privileges of the user that
> > initialized the group, not the privileges of the user reading the
> > events.
> >
> > Use an internal group flag FANOTIFY_UNPRIV to record the fact that the
> > group was initialized by an unprivileged user.
> >
> > To be on the safe side, the premissions to setup filesystem and mount
> > marks now require that both the user that initialized the group and
> > the user setting up the mark have CAP_SYS_ADMIN.
> >
> > Link: https://lore.kernel.org/linux-fsdevel/CAOQ4uxiA77_P5vtv7e83g0+9d7B5W9ZTE4GfQEYbWmfT1rA=VA@mail.gmail.com/
> > Fixes: 7cea2a3c505e ("fanotify: support limited functionality for unprivileged users")
> > Cc: <Stable@vger.kernel.org> # v5.12+
>
> Why is this marked for 5.12+ when 7cea2a3c505e ("fanotify: support
> limited functionality for unprivileged users") showed up in 5.13-rc1?
>
> What am I supposed to do with this for a stable tree submission?
I think Amir got confused and didn't realize the functionality got merged
only in 5.13 merge window and I didn't notice when merging the patch
either. I'm sorry, please just ignore the fix.
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2021-06-08 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 13:53 [PATCH][v2] fanotify: fix permission model of unprivileged group Amir Goldstein
2021-05-24 23:13 ` Matthew Bobrowski
2021-05-25 10:14 ` Jan Kara
2021-05-25 10:15 ` Christian Brauner
2021-05-25 13:23 ` Amir Goldstein
2021-06-08 12:21 ` Greg KH
2021-06-08 12:28 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210608122829.GI5562@quack2.suse.cz \
--to=jack@suse.cz \
--cc=amir73il@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mbobrowski@mbobrowski.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox