From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBC1FC48BE6 for ; Tue, 15 Jun 2021 02:36:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9AEEB61166 for ; Tue, 15 Jun 2021 02:36:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231132AbhFOCii (ORCPT ); Mon, 14 Jun 2021 22:38:38 -0400 Received: from mail.kernel.org ([198.145.29.99]:45816 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229829AbhFOCig (ORCPT ); Mon, 14 Jun 2021 22:38:36 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1A3E9613F1; Tue, 15 Jun 2021 01:17:47 +0000 (UTC) Date: Mon, 14 Jun 2021 21:17:45 -0400 From: Steven Rostedt To: Andrew Morton Cc: Alexey Dobriyan , dhowells@redhat.com, linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, Andi Kleen , "Paul E. McKenney" Subject: Re: [PATCH] afs: fix tracepoint string placement with built-in AFS Message-ID: <20210614211745.6eb3d9ca@oasis.local.home> In-Reply-To: <20210614164752.12438695a27203c8e7c9eaea@linux-foundation.org> References: <20210614164752.12438695a27203c8e7c9eaea@linux-foundation.org> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Mon, 14 Jun 2021 16:47:52 -0700 Andrew Morton wrote: > Should/can afs_SRXCB##name##_name[] be static? Probably. > > > __tracepoint_string is very rarely used. I wonder if there's much > point in it existing? There's a few places that the "tracepoint_string()" couldn't be used, and this was a workaround for those locations. Yes, it's not used much, but what's the other solution should we use to replace it? > > > kernel/rcu/tree.h does > > static char rcu_name[] = RCU_NAME_RAW; > static const char *tp_rcu_varname __used __tracepoint_string = rcu_name; > > which is asking the compiler to place a copy of these into each > compilation unit which includes tree.h, which probably isn't what was > intended. Yeah, there's a couple of duplicates. Perhaps we can move them into a C file, and have it simply exported. -- Steve