From: Steven Rostedt <rostedt@goodmis.org>
To: David Howells <dhowells@redhat.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
akpm@linux-foundation.org, linux-afs@lists.infradead.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] afs: fix tracepoint string placement with built-in AFS
Date: Tue, 15 Jun 2021 11:54:53 -0400 [thread overview]
Message-ID: <20210615115453.63bc3a63@oasis.local.home> (raw)
In-Reply-To: <643721.1623754699@warthog.procyon.org.uk>
On Tue, 15 Jun 2021 11:58:19 +0100
David Howells <dhowells@redhat.com> wrote:
> @@ -649,20 +705,21 @@ TRACE_EVENT(afs_cb_call,
>
> TP_STRUCT__entry(
> __field(unsigned int, call )
> - __field(const char *, name )
> __field(u32, op )
> + __field(u16, service_id )
> ),
>
> TP_fast_assign(
> __entry->call = call->debug_id;
> - __entry->name = call->type->name;
> __entry->op = call->operation_ID;
> + __entry->service_id = call->service_id;
> ),
>
> - TP_printk("c=%08x %s o=%u",
> + TP_printk("c=%08x %s",
> __entry->call,
> - __entry->name,
> - __entry->op)
> + __entry->service_id == 2501 ?
> + __print_symbolic(__entry->op, yfs_cm_operations) :
> + __print_symbolic(__entry->op, afs_cm_operations))
> );
>
> TRACE_EVENT(afs_call,
Looks fine to me, and even saves 4 bytes on 64 bit machines (events are
rounded up to 4 byte increments, so the u16 is no different than a u32
here).
-- Steve
next prev parent reply other threads:[~2021-06-15 15:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 22:04 [PATCH] afs: fix tracepoint string placement with built-in AFS Alexey Dobriyan
2021-06-14 16:07 ` Alexey Dobriyan
2021-06-14 23:47 ` Andrew Morton
2021-06-15 1:17 ` Steven Rostedt
2021-06-15 8:19 ` David Howells
2021-06-15 8:49 ` David Howells
2021-06-15 10:58 ` David Howells
2021-06-15 15:54 ` Steven Rostedt [this message]
2021-06-17 12:04 ` David Howells
2021-06-17 13:37 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2021-06-21 20:57 [PATCH] afs: Fix " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210615115453.63bc3a63@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dhowells@redhat.com \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).