linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "bfields@fieldses.org" <bfields@fieldses.org>
To: NeilBrown <neilb@suse.de>
Cc: Trond Myklebust <trondmy@hammerspace.com>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"dai.ngo@oracle.com" <dai.ngo@oracle.com>,
	"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: automatic freeing of space on ENOSPC
Date: Tue, 29 Jun 2021 14:32:57 -0400	[thread overview]
Message-ID: <20210629183257.GA1926@fieldses.org> (raw)
In-Reply-To: <162493102550.7211.15170485925982544813@noble.neil.brown.name>

On Tue, Jun 29, 2021 at 11:43:45AM +1000, NeilBrown wrote:
> I wonder how important this is.  If an NFS client unlinks a file that it
> has open, it will be silly_renamed, and if the client then goes silent,
> it might never be removed.  So we already theoretically have a
> possibilty of ENOSPC due to silent clients.  Have we heard of this
> becoming a problem?

Oh, that's a good point.  I've seen complaints about sillyrename files,
but I can't recall ever seen a single complaint about their causing
ENOSPC.

> Is there reason to think that the Courteous server changes will make
> this problem more likely? 

So I guess the only new cases the courteous server will introduce are
even less likely (probably just the case where a file is unlinked by a
client other than the one that has it open).

So I think doing nothing for now is an acceptable alternative....

--b.

  parent reply	other threads:[~2021-06-29 18:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-28 19:49 automatic freeing of space on ENOSPC J. Bruce Fields
2021-06-29  0:43 ` Trond Myklebust
2021-06-29  1:12   ` bfields
2021-06-29  1:43     ` NeilBrown
2021-06-29  4:07       ` Amir Goldstein
2021-06-29 18:34         ` bfields
2021-06-29 18:32       ` bfields [this message]
2021-06-29 18:39         ` Chuck Lever III
2021-06-29  5:11 ` Dave Chinner
2021-06-29 18:37   ` J. Bruce Fields
2021-06-29 16:47 ` Theodore Ts'o
2021-06-29 18:38   ` J. Bruce Fields

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210629183257.GA1926@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=dai.ngo@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).