From: Christoph Hellwig <hch@lst.de>
To: Matthew Wilcox <willy@infradead.org>
Cc: Christian Brauner <brauner@kernel.org>,
Christoph Hellwig <hch@lst.de>, Chris Mason <clm@fb.com>,
Josef Bacik <josef@toxicpanda.com>,
David Sterba <dsterba@suse.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-btrfs@vger.kernel.org,
Christian Brauner <christian.brauner@ubuntu.com>,
Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3 01/21] namei: add mapping aware lookup helper
Date: Mon, 26 Jul 2021 16:45:40 +0200 [thread overview]
Message-ID: <20210726144540.GA12779@lst.de> (raw)
In-Reply-To: <YP7JgZCb/AAG17xf@casper.infradead.org>
On Mon, Jul 26, 2021 at 03:41:05PM +0100, Matthew Wilcox wrote:
> On Mon, Jul 26, 2021 at 12:27:56PM +0200, Christian Brauner wrote:
> > +/**
> > + * lookup_mapped_one_len - filesystem helper to lookup single pathname component
>
> Can we think about the name a bit? In the ur-times (2.3.99), we had
> lookup_dentry(), which as far as I can tell walked an entire path.
> That got augmented with lookup_one() which just walked a single path
> entry. That was replaced with lookup_one_len() which added the 'len'
> parameter. Now we have:
>
> struct dentry *try_lookup_one_len(const char *, struct dentry *, int);
> struct dentry *lookup_one_len(const char *, struct dentry *, int);
> struct dentry *lookup_one_len_unlocked(const char *, struct dentry *, int);
> struct dentry *lookup_positive_unlocked(const char *, struct dentry *, int);
>
> I think the 'len' part of the name has done its job, and this new
> helper should be 'lookup_one_mapped'.
Heh. I'd drop the mapped as well as this should be the new normal
going ahead.
next prev parent reply other threads:[~2021-07-26 14:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210726102816.612434-1-brauner@kernel.org>
2021-07-26 10:27 ` [PATCH v3 01/21] namei: add mapping aware lookup helper Christian Brauner
2021-07-26 14:41 ` Matthew Wilcox
2021-07-26 14:45 ` Christoph Hellwig [this message]
2021-07-26 16:10 ` Christian Brauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726144540.GA12779@lst.de \
--to=hch@lst.de \
--cc=brauner@kernel.org \
--cc=christian.brauner@ubuntu.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).