From: Jan Kara <jack@suse.cz>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Jan Kara <jack@suse.cz>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH -next] filesystems/locking: fix Malformed table warning
Date: Wed, 28 Jul 2021 15:20:44 +0200 [thread overview]
Message-ID: <20210728132044.GH29619@quack2.suse.cz> (raw)
In-Reply-To: <20210728000409.GE559142@magnolia>
On Tue 27-07-21 17:04:09, Darrick J. Wong wrote:
> On Tue, Jul 27, 2021 at 04:22:12PM -0700, Randy Dunlap wrote:
> > Update the bottom border to be the same as the top border.
> >
> > Documentation/filesystems/locking.rst:274: WARNING: Malformed table.
> > Bottom/header table border does not match top border.
> >
> > Fixes: 730633f0b7f9 ("mm: Protect operations adding pages to page cache with invalidate_lock")
> > Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> > Cc: Darrick J. Wong <djwong@kernel.org>
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Jan Kara <jack@suse.cz>
> > Cc: linux-fsdevel@vger.kernel.org
>
> Looks ugly but probably correct
> Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Thanks for the fix and for review! I've added the patch to my branch with
hole punch fixes.
Honza
> > ---
> > Documentation/filesystems/locking.rst | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linext-20210727.orig/Documentation/filesystems/locking.rst
> > +++ linext-20210727/Documentation/filesystems/locking.rst
> > @@ -295,7 +295,7 @@ is_partially_uptodate: yes
> > error_remove_page: yes
> > swap_activate: no
> > swap_deactivate: no
> > -====================== ======================== =========
> > +====================== ======================== ========= ===============
> >
> > ->write_begin(), ->write_end() and ->readpage() may be called from
> > the request handler (/dev/loop).
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
prev parent reply other threads:[~2021-07-28 13:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 23:22 [PATCH -next] filesystems/locking: fix Malformed table warning Randy Dunlap
2021-07-28 0:04 ` Darrick J. Wong
2021-07-28 13:20 ` Jan Kara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210728132044.GH29619@quack2.suse.cz \
--to=jack@suse.cz \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).