From: Andrew Morton <akpm@linux-foundation.org>
To: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, richard@sigma-star.at
Subject: Re: [PATCH] Log if a core dump is aborted due to changed file permissions
Date: Mon, 2 Aug 2021 14:40:20 -0700 [thread overview]
Message-ID: <20210802144020.1d898eeaedc615776b0d2996@linux-foundation.org> (raw)
In-Reply-To: <20210701233151.102720-1-david.oberhollenzer@sigma-star.at>
On Fri, 2 Jul 2021 01:31:51 +0200 David Oberhollenzer <david.oberhollenzer@sigma-star.at> wrote:
> For obvious security reasons, a core dump is aborted if the
> filesystem cannot preserve ownership or permissions of the
> dump file.
>
> This affects filesystems like e.g. vfat, but also something like
> a 9pfs share in a Qemu test setup, running as a regular user,
> depending on the security model used. In those cases, the result
> is an empty core file and a confused user.
>
> To hopefully safe other people a lot of time figuring out the
> cause, this patch adds a simple log message for those specific
> cases.
Seems sane.
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -782,10 +777,17 @@ void do_coredump(const kernel_siginfo_t *siginfo)
> * filesystem.
> */
> mnt_userns = file_mnt_user_ns(cprm.file);
> - if (!uid_eq(i_uid_into_mnt(mnt_userns, inode), current_fsuid()))
> + if (!uid_eq(i_uid_into_mnt(mnt_userns, inode),
> + current_fsuid())) {
> + pr_info_ratelimited("Core dump to |%s aborted: cannot preserve file owner\n",
But why the "|%s"? This signifies dump-to-pipe, yes? Don't we need
the below?
--- a/fs/coredump.c~log-if-a-core-dump-is-aborted-due-to-changed-file-permissions-fix
+++ a/fs/coredump.c
@@ -784,12 +784,12 @@ void do_coredump(const kernel_siginfo_t
mnt_userns = file_mnt_user_ns(cprm.file);
if (!uid_eq(i_uid_into_mnt(mnt_userns, inode),
current_fsuid())) {
- pr_info_ratelimited("Core dump to |%s aborted: cannot preserve file owner\n",
+ pr_info_ratelimited("Core dump to %s aborted: cannot preserve file owner\n",
cn.corename);
goto close_fail;
}
if ((inode->i_mode & 0677) != 0600) {
- pr_info_ratelimited("Core dump to |%s aborted: cannot preserve file permissions\n",
+ pr_info_ratelimited("Core dump to %s aborted: cannot preserve file permissions\n",
cn.corename);
goto close_fail;
}
_
prev parent reply other threads:[~2021-08-02 21:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-01 23:31 [PATCH] Log if a core dump is aborted due to changed file permissions David Oberhollenzer
2021-08-02 20:47 ` David Oberhollenzer
2021-08-02 21:40 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210802144020.1d898eeaedc615776b0d2996@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=david.oberhollenzer@sigma-star.at \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@sigma-star.at \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).