From: "Darrick J. Wong" <djwong@kernel.org>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] iomap: pass writeback errors to the mapping
Date: Mon, 9 Aug 2021 16:35:23 -0700 [thread overview]
Message-ID: <20210809233523.GQ3601466@magnolia> (raw)
In-Reply-To: <YQxiVxSWWwZwoqbZ@casper.infradead.org>
On Thu, Aug 05, 2021 at 11:12:39PM +0100, Matthew Wilcox wrote:
> On Thu, Aug 05, 2021 at 02:31:54PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@kernel.org>
> >
> > Modern-day mapping_set_error has the ability to squash the usual
> > negative error code into something appropriate for long-term storage in
> > a struct address_space -- ENOSPC becomes AS_ENOSPC, and everything else
> > becomes EIO. iomap squashes /everything/ to EIO, just as XFS did before
> > that, but this doesn't make sense.
> >
> > Fix this by making it so that we can pass ENOSPC to userspace when
> > writeback fails due to space problems.
> >
> > Signed-off-by: Darrick J. Wong <djwong@kernel.org>
>
> I could have sworn I sent this patch in earlier. Anyway,
>
> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
It was an RFC that I then forgot about for a while. I'll stuff this in
the iomap for-next branch the next time I do an update, which ... let's
see where the iomap iter series goes, review-wise.
--D
prev parent reply other threads:[~2021-08-09 23:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 21:31 [PATCH] iomap: pass writeback errors to the mapping Darrick J. Wong
2021-08-05 22:12 ` Matthew Wilcox
2021-08-09 23:35 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210809233523.GQ3601466@magnolia \
--to=djwong@kernel.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).