From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85C26C4338F for ; Tue, 10 Aug 2021 13:42:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6062D61058 for ; Tue, 10 Aug 2021 13:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238369AbhHJNmf (ORCPT ); Tue, 10 Aug 2021 09:42:35 -0400 Received: from verein.lst.de ([213.95.11.211]:36237 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238252AbhHJNmf (ORCPT ); Tue, 10 Aug 2021 09:42:35 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 681DC68AFE; Tue, 10 Aug 2021 15:42:09 +0200 (CEST) Date: Tue, 10 Aug 2021 15:42:09 +0200 From: Christoph Hellwig To: Christian Brauner Cc: Christoph Hellwig , Chris Mason , Josef Bacik , David Sterba , Al Viro , linux-btrfs@vger.kernel.org, Christian Brauner , Christoph Hellwig , Matthew Wilcox , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v4 01/21] namei: add mapping aware lookup helper Message-ID: <20210810134209.GA13122@lst.de> References: <20210727104900.829215-1-brauner@kernel.org> <20210727104900.829215-2-brauner@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210727104900.829215-2-brauner@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org No need for the extern on the prototype, but otherwise looks good: Reviewed-by: Christoph Hellwig