From: kernel test robot <lkp@intel.com>
To: "Caleb D.S. Brzezinski" <calebdsb@protonmail.com>,
hirofumi@mail.parknet.co.jp
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
"Caleb D.S. Brzezinski" <calebdsb@protonmail.com>
Subject: [RFC PATCH] fat: msdos_ncache can be static
Date: Mon, 30 Aug 2021 05:05:37 +0800 [thread overview]
Message-ID: <20210829210537.GA61694@74a5018f4101> (raw)
In-Reply-To: <20210829142459.56081-2-calebdsb@protonmail.com>
fs/fat/namei_msdos.c:37:1: warning: symbol 'msdos_ncache' was not declared. Should it be static?
fs/fat/namei_msdos.c:38:1: warning: symbol 'msdos_ncache_mutex' was not declared. Should it be static?
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
namei_msdos.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/fat/namei_msdos.c b/fs/fat/namei_msdos.c
index 7561674b16a22..f44d590a11583 100644
--- a/fs/fat/namei_msdos.c
+++ b/fs/fat/namei_msdos.c
@@ -34,8 +34,8 @@ struct msdos_name_node {
struct hlist_node h_list;
};
-DEFINE_HASHTABLE(msdos_ncache, 6);
-DEFINE_MUTEX(msdos_ncache_mutex); /* protect the name cache */
+static DEFINE_HASHTABLE(msdos_ncache, 6);
+static DEFINE_MUTEX(msdos_ncache_mutex); /* protect the name cache */
/**
* msdos_fname_hash() - quickly "hash" an msdos filename
next prev parent reply other threads:[~2021-08-29 21:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-29 14:25 [PATCH 0/3] fat: add a cache for msdos_format_name() Caleb D.S. Brzezinski
2021-08-29 14:25 ` [PATCH 1/3] fat: define functions and data structures for a formatted name cache Caleb D.S. Brzezinski
2021-08-29 21:05 ` kernel test robot
2021-08-29 21:05 ` kernel test robot [this message]
2021-08-29 14:25 ` [PATCH 2/3] fat: add the msdos_format_name() filename cache Caleb D.S. Brzezinski
2021-08-29 15:11 ` Al Viro
2021-08-29 15:26 ` Al Viro
2021-08-29 17:19 ` Caleb D.S. Brzezinski
2021-08-29 17:11 ` Caleb D.S. Brzezinski
2021-08-29 21:23 ` Al Viro
2021-08-29 14:25 ` [PATCH 3/3] fat: add hash machinery to relevant filesystem operations Caleb D.S. Brzezinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210829210537.GA61694@74a5018f4101 \
--to=lkp@intel.com \
--cc=calebdsb@protonmail.com \
--cc=hirofumi@mail.parknet.co.jp \
--cc=kbuild-all@lists.01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).