From: Jan Harkes <jaharkes@cs.cmu.edu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Jan Harkes <jaharkes@cs.cmu.edu>, linux-fsdevel@vger.kernel.org
Subject: [PATCH 4/9] coda: Avoid flagging NULL inodes
Date: Wed, 8 Sep 2021 10:03:03 -0400 [thread overview]
Message-ID: <20210908140308.18491-5-jaharkes@cs.cmu.edu> (raw)
In-Reply-To: <20210908140308.18491-1-jaharkes@cs.cmu.edu>
Somehow we hit a negative dentry in coda_rename even after checking
with d_really_is_positive. Maybe something raced and turned the
new_dentry negative while we were fixing up directory link counts.
Signed-off-by: Jan Harkes <jaharkes@cs.cmu.edu>
---
fs/coda/coda_linux.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/coda/coda_linux.h b/fs/coda/coda_linux.h
index e7b27754ce78..3c2947bba5e5 100644
--- a/fs/coda/coda_linux.h
+++ b/fs/coda/coda_linux.h
@@ -83,6 +83,9 @@ static __inline__ void coda_flag_inode(struct inode *inode, int flag)
{
struct coda_inode_info *cii = ITOC(inode);
+ if (!inode)
+ return;
+
spin_lock(&cii->c_lock);
cii->c_flags |= flag;
spin_unlock(&cii->c_lock);
--
2.25.1
next prev parent reply other threads:[~2021-09-08 14:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-08 14:02 [PATCH 0/9] Coda updates for -next Jan Harkes
2021-09-08 14:03 ` [PATCH 1/9] coda: Avoid NULL pointer dereference from a bad inode Jan Harkes
2021-09-08 14:03 ` [PATCH 2/9] coda: Check for async upcall request using local state Jan Harkes
2021-09-08 14:03 ` [PATCH 3/9] coda: remove err which no one care Jan Harkes
2021-09-08 14:03 ` Jan Harkes [this message]
2021-09-08 14:03 ` [PATCH 5/9] coda: Avoid hidden code duplication in rename Jan Harkes
2021-09-08 14:03 ` [PATCH 6/9] coda: Avoid doing bad things on inode type changes during revalidation Jan Harkes
2021-09-08 14:03 ` [PATCH 7/9] coda: Convert from atomic_t to refcount_t on coda_vm_ops->refcnt Jan Harkes
2021-09-08 14:03 ` [PATCH 8/9] coda: Use vmemdup_user to replace the open code Jan Harkes
2021-09-08 14:03 ` [PATCH 9/9] coda: Bump module version to 7.2 Jan Harkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210908140308.18491-5-jaharkes@cs.cmu.edu \
--to=jaharkes@cs.cmu.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).