From: Jan Kara <jack@suse.cz>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-fsdevel@vger.kernel.org, dan.j.williams@intel.com
Subject: Re: [PATCH 2/3] ext4: remove dax EXPERIMENTAL warning
Date: Fri, 17 Sep 2021 11:47:37 +0200 [thread overview]
Message-ID: <20210917094737.GE6547@quack2.suse.cz> (raw)
In-Reply-To: <1631726561-16358-3-git-send-email-sandeen@redhat.com>
On Wed 15-09-21 12:22:40, Eric Sandeen wrote:
> As there seems to be no significant outstanding concern about
> dax on ext4 at this point, remove the scary EXPERIMENTAL
> warning when in use.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
I agree. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/ext4/super.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 0775950..82948d6 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -2346,8 +2346,6 @@ static int handle_mount_opt(struct super_block *sb, char *opt, int token,
> "both data=journal and dax");
> return -1;
> }
> - ext4_msg(sb, KERN_WARNING,
> - "DAX enabled. Warning: EXPERIMENTAL, use at your own risk");
> sbi->s_mount_opt |= EXT4_MOUNT_DAX_ALWAYS;
> sbi->s_mount_opt2 &= ~EXT4_MOUNT2_DAX_NEVER;
> break;
> --
> 1.8.3.1
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2021-09-17 9:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 17:22 [PATCH 0/3 RFC] Remove DAX experimental warnings Eric Sandeen
2021-09-15 17:22 ` [PATCH 1/3] xfs: remove dax EXPERIMENTAL warning Eric Sandeen
2021-09-15 18:54 ` Dan Williams
2021-09-15 17:22 ` [PATCH 2/3] ext4: " Eric Sandeen
2021-09-17 9:47 ` Jan Kara [this message]
2021-09-15 17:22 ` [PATCH 3/3] ext2: " Eric Sandeen
2021-09-17 9:47 ` Jan Kara
2021-09-17 12:59 ` Christoph Hellwig
2021-09-17 14:09 ` Eric Sandeen
2021-09-22 2:36 ` Darrick J. Wong
2021-09-22 5:25 ` Christoph Hellwig
2021-09-15 18:35 ` [PATCH 0/3 RFC] Remove DAX experimental warnings Dan Williams
2021-09-15 18:48 ` Eric Sandeen
2021-09-15 18:59 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210917094737.GE6547@quack2.suse.cz \
--to=jack@suse.cz \
--cc=dan.j.williams@intel.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).