From: David Disseldorp <ddiss@suse.de>
To: linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org
Cc: viro@zeniv.linux.org.uk, willy@infradead.org,
David Disseldorp <ddiss@suse.de>
Subject: [PATCH 4/5] initramfs: use do_utime() wrapper consistently
Date: Wed, 22 Sep 2021 13:52:21 +0200 [thread overview]
Message-ID: <20210922115222.8987-4-ddiss@suse.de> (raw)
In-Reply-To: <20210922115222.8987-1-ddiss@suse.de>
vfs_utimes() is called via the do_utime() wrapper everywhere except in
do_copy(). Make it consistent.
Signed-off-by: David Disseldorp <ddiss@suse.de>
---
init/initramfs.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/init/initramfs.c b/init/initramfs.c
index 19b1c70446fc..7f809a1c8e89 100644
--- a/init/initramfs.c
+++ b/init/initramfs.c
@@ -378,13 +378,9 @@ static int __init do_name(void)
static int __init do_copy(void)
{
if (byte_count >= body_len) {
- struct timespec64 t[2] = { };
if (xwrite(wfile, victim, body_len, &wfile_pos) != body_len)
error("write error");
-
- t[0].tv_sec = mtime;
- t[1].tv_sec = mtime;
- vfs_utimes(&wfile->f_path, t);
+ do_utime(collected, mtime);
fput(wfile);
eat(body_len);
--
2.31.1
next prev parent reply other threads:[~2021-09-22 11:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-22 11:52 [PATCH 1/5] initramfs: move unnecessary memcmp from hot path David Disseldorp
2021-09-22 11:52 ` [PATCH 2/5] initramfs: print helpful cpio error on "crc" magic David Disseldorp
2021-09-22 11:52 ` [PATCH v2 3/5] docs: remove mention of "crc" cpio format support David Disseldorp
2021-09-22 11:52 ` David Disseldorp [this message]
2021-09-22 11:52 ` [PATCH 5/5] initramfs: add INITRAMFS_PRESERVE_MTIME Kconfig option David Disseldorp
2021-09-22 23:28 ` [PATCH 1/5] initramfs: move unnecessary memcmp from hot path Chaitanya Kulkarni
2021-09-23 7:43 ` David Disseldorp
2021-09-22 23:35 ` Al Viro
2021-09-22 23:51 ` Chaitanya Kulkarni
2021-09-23 7:33 ` David Disseldorp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210922115222.8987-4-ddiss@suse.de \
--to=ddiss@suse.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).