From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F78DC433F5 for ; Wed, 22 Sep 2021 17:48:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA88A61156 for ; Wed, 22 Sep 2021 17:48:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236919AbhIVRta (ORCPT ); Wed, 22 Sep 2021 13:49:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47394 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233552AbhIVRta (ORCPT ); Wed, 22 Sep 2021 13:49:30 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1532EC061574; Wed, 22 Sep 2021 10:48:00 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id g41so14942046lfv.1; Wed, 22 Sep 2021 10:47:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=G9y8WEbtY6QF6b57YEwGzQEUKD9V6Jk3RH25jdHrWA8=; b=ggWl8gcJTzUpXp3eY8NqlJVCF7ShGCpHCNZbGbp85TgSMwj/mnxhcTzu6neTRUCK3P 1Iuem+0ehT4+ne3pUWaabQZ2f+E6Q+yiTvZc2kUnyh8NkygS/6HTuN3RGb1SxmIHl+XO NSP67FnHAsAI8/gXIWbWvLd5SkR37lBIBssMzz1LgsQId2VKDarFcKuug5Q36l96se1j KTErk6wFZi1hYXBL2bKUxRPqXHvH8kI9lvlaH9rfpODd5Nl3NLyD6nqSt58yIzCYyow3 l1fHia7Z3jRtX7nAERN/PzKjKSc/jMP31n7ZHNAnOYalvPl3eQSQ6v2QGZdK5btz7uIo ohhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=G9y8WEbtY6QF6b57YEwGzQEUKD9V6Jk3RH25jdHrWA8=; b=51OcQLckbgLqVAXXfeIYIvUOL6xuXetOLkVStqvhI9SDgMq+z9iFV9vHHDrSI6vUU5 rdh5zcF+jqQOzz/BCve2+gEXzI6s3cLCqz5weJ8OicmWug2UyyKf/xRCCo9UX/TEckdX KE14q9dYVk+AboaVgt5sP1VNFLS1rsmQ6JvryYW+LVvB1n9Zr3NMTnUOyd0RminIFsyn dGbrMJcM5NEwkUdVjCL+iChBm8yLMK0pOh0+JR0F2RKpSnSnuvlUfw+Cg8yFbzC4NWPW qUndkGaflsQOGigG32BUWUT7hDOHL6WBGnVgp9FZ1RHns8OltbiJIspDpHwuo01f/x1O OIcA== X-Gm-Message-State: AOAM530ORIHUBYQ04DMqtPTihvaBooTKbyanXTPj8gUzm90qC1hEoBOx L8ZTIQ2EK7g+17jNK+vpMEGTUKmMLSk33w== X-Google-Smtp-Source: ABdhPJxLK1CR/TgTp0A+dm819in8n44WpkccKCLelGAjOyHWB4aQIjh70pJqKUZawLll4Y+6l8PcRQ== X-Received: by 2002:ac2:4e04:: with SMTP id e4mr249999lfr.262.1632332878397; Wed, 22 Sep 2021 10:47:58 -0700 (PDT) Received: from kari-VirtualBox ([31.132.12.44]) by smtp.gmail.com with ESMTPSA id v11sm229171lfi.56.2021.09.22.10.47.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 22 Sep 2021 10:47:57 -0700 (PDT) Date: Wed, 22 Sep 2021 20:47:56 +0300 From: Kari Argillander To: Konstantin Komarov Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 2/5] fs/ntfs3: Refactor ntfs_get_acl_ex for better readability Message-ID: <20210922174756.cgj66om2qro4ms3j@kari-VirtualBox> References: <2771ff62-e612-a8ed-4b93-5534c26aef9e@paragon-software.com> <994cb658-d2f8-a797-e947-35ac0a203ea2@paragon-software.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <994cb658-d2f8-a797-e947-35ac0a203ea2@paragon-software.com> Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Wed, Sep 22, 2021 at 07:18:18PM +0300, Konstantin Komarov wrote: There should almoust always still be commit message. Even "small" change. You have now see that people send you patch which change just one line, but it can still contain many lines commit message. > Signed-off-by: Konstantin Komarov > --- > fs/ntfs3/xattr.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c > index 5c7c5c7a5ec1..3795943efc8e 100644 > --- a/fs/ntfs3/xattr.c > +++ b/fs/ntfs3/xattr.c > @@ -518,12 +518,15 @@ static struct posix_acl *ntfs_get_acl_ex(struct user_namespace *mnt_userns, > /* Translate extended attribute to acl. */ > if (err >= 0) { If err was ENODATA ... > acl = posix_acl_from_xattr(mnt_userns, buf, err); > - if (!IS_ERR(acl)) > - set_cached_acl(inode, type, acl); > + } else if (err == -ENODATA) { > + acl = NULL; > } else { > - acl = err == -ENODATA ? NULL : ERR_PTR(err); Before we get this and we did not call set_cached_acl(). > + acl = ERR_PTR(err); > } > > + if (!IS_ERR(acl)) But now we call it with new logic. If this is correct then you change behavier little bit. I let you talk before I look more into this. > + set_cached_acl(inode, type, acl); > + > __putname(buf); > > return acl; > -- > 2.33.0 > >