From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7849AC433EF for ; Sat, 25 Sep 2021 08:50:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 535C26108B for ; Sat, 25 Sep 2021 08:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235235AbhIYIvw (ORCPT ); Sat, 25 Sep 2021 04:51:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232623AbhIYIvw (ORCPT ); Sat, 25 Sep 2021 04:51:52 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6ECFAC061570; Sat, 25 Sep 2021 01:50:17 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id z24so51683011lfu.13; Sat, 25 Sep 2021 01:50:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IQgDYfiWEiQEpbbYGFHiSZcPZ0HKpZyuv+m5Uj0Q7bc=; b=ipVH7Z0kEWMasWb9TInu0N7M+mjgjidioW+2I/92X48jDaQTT1d60vyS422ebpUV0W NYaaZ7Mv1zhCULo5K/Y5TkdA6sAss7Cn9rXWmH0QiwTPcSr7UwLHS6VcWJZ4vFJQWK8O lN34z+grQ8OfPkk7u6nXMEaQZE01DuBQIMcpqfycQhm9uXZ/LgO1GcPRXjGNZjE1gets vNmfCnDh8+oay+sZnj15ght2BYX8w21AYyZHZ2toW2aqab75qATFAxpK9xasrTbzWRO8 Qy+OeTXq5+iw2HwFMasfknevcquL077c1SVi3Fa16jAf24li+N7IstHZClqCLdsJfd3z d7GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IQgDYfiWEiQEpbbYGFHiSZcPZ0HKpZyuv+m5Uj0Q7bc=; b=O+ugyGR0r9zYpWO/IHCNDGKqNKq/1bGELpSpNoZoJdyEPZr+3El2ZM64ABF5E3YZNJ /BhbftAe7x9PHpVYOLIaoHd+Qyg7xsW+b+cWvaI3mhiGCRg0jlTu5EzWtLEWud5e/ZII rTgS+v5weMjSEfWwK+ZT/sZuTJjpHuCn7HFpRHlboSSP6lpIPfVOgc3FDWetIKltPbSA z18kukW/VWw4az3GVjCbc9ARRrMQU+NxDJw9d6fTgbJc4cLuFGc7YO2bcx5vA63gEguA qTVeX5RtR04fx/0sdsWVjSgmiee+7JRVV9M/ARyWaj5RTAoHHcdFapPAlZ3iEVIuyr/L PAxg== X-Gm-Message-State: AOAM533zwL6q/uiLM5zCHfACujyMdLN4B7475DkqF3iitPqqyp9R9UPH YxOFomRVWAJl7953qwde1NQ= X-Google-Smtp-Source: ABdhPJx4WPc/B9g65Cit+/OKgWAPcuY4GcG/h/VgSUKQvbLHHI8E/L48kzO3Wg7KZIMu3uxOZEfBRw== X-Received: by 2002:a2e:4c12:: with SMTP id z18mr15502203lja.364.1632559815829; Sat, 25 Sep 2021 01:50:15 -0700 (PDT) Received: from kari-VirtualBox (85-23-89-224.bb.dnainternet.fi. [85.23.89.224]) by smtp.gmail.com with ESMTPSA id z14sm1092473lji.102.2021.09.25.01.50.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 25 Sep 2021 01:50:15 -0700 (PDT) Date: Sat, 25 Sep 2021 11:50:13 +0300 From: Kari Argillander To: Konstantin Komarov Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 1/3] fs/ntfs3: Use available posix_acl_release instead of ntfs_posix_acl_release Message-ID: <20210925085013.e2mz4piogs75aipp@kari-VirtualBox> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Fri, Sep 24, 2021 at 07:14:53PM +0300, Konstantin Komarov wrote: > We don't need to maintain ntfs_posix_acl_release. > > Signed-off-by: Konstantin Komarov Reviewed-by: Kari Argillander > --- > fs/ntfs3/xattr.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/fs/ntfs3/xattr.c b/fs/ntfs3/xattr.c > index 83bbee277e12..253a07d9aa7b 100644 > --- a/fs/ntfs3/xattr.c > +++ b/fs/ntfs3/xattr.c > @@ -475,12 +475,6 @@ static noinline int ntfs_set_ea(struct inode *inode, const char *name, > } > > #ifdef CONFIG_NTFS3_FS_POSIX_ACL > -static inline void ntfs_posix_acl_release(struct posix_acl *acl) > -{ > - if (acl && refcount_dec_and_test(&acl->a_refcount)) > - kfree(acl); > -} > - > static struct posix_acl *ntfs_get_acl_ex(struct user_namespace *mnt_userns, > struct inode *inode, int type, > int locked) > @@ -641,7 +635,7 @@ static int ntfs_xattr_get_acl(struct user_namespace *mnt_userns, > return -ENODATA; > > err = posix_acl_to_xattr(mnt_userns, acl, buffer, size); > - ntfs_posix_acl_release(acl); > + posix_acl_release(acl); > > return err; > } > @@ -678,7 +672,7 @@ static int ntfs_xattr_set_acl(struct user_namespace *mnt_userns, > err = ntfs_set_acl(mnt_userns, inode, acl, type); > > release_and_out: > - ntfs_posix_acl_release(acl); > + posix_acl_release(acl); > return err; > } > > -- > 2.33.0 > >