From: Kari Argillander <kari.argillander@gmail.com>
To: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Cc: ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v2 0/3] fs/ntfs3: Refactoring of xattr.c
Date: Mon, 27 Sep 2021 22:02:01 +0300 [thread overview]
Message-ID: <20210927190201.yhlipxcitremds3e@kari-VirtualBox> (raw)
In-Reply-To: <a1204ce8-80e6-bf44-e7d1-f1674ff28dcd@paragon-software.com>
On Mon, Sep 27, 2021 at 06:26:26PM +0300, Konstantin Komarov wrote:
> Removed function, that already have been in kernel.
> Changed locking policy to fix some potential bugs.
> Changed code for readability.
>
> V2:
> fixed typo.
In the future please tell more closly. Now reviewr has to check
everything again. It is also good thing to write if someone suggest it.
Then that person can see right away that you change what he/she
suggested.
Also usually when someone comment something to previes series version
then you take all commenters to cc list. Usually reviewer will might
wanna give reviewed-by tag after you change what suggested.
>
> Konstantin Komarov (3):
> fs/ntfs3: Use available posix_acl_release instead of
> ntfs_posix_acl_release
> fs/ntfs3: Remove locked argument in ntfs_set_ea
> fs/ntfs3: Refactoring of ntfs_set_ea
>
> fs/ntfs3/xattr.c | 69 ++++++++++++++++++++++--------------------------
> 1 file changed, 32 insertions(+), 37 deletions(-)
>
> --
> 2.33.0
>
prev parent reply other threads:[~2021-09-27 19:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-27 15:26 [PATCH v2 0/3] fs/ntfs3: Refactoring of xattr.c Konstantin Komarov
2021-09-27 15:27 ` [PATCH v2 1/3] fs/ntfs3: Use available posix_acl_release instead of ntfs_posix_acl_release Konstantin Komarov
2021-09-27 15:28 ` [PATCH v2 2/3] fs/ntfs3: Remove locked argument in ntfs_set_ea Konstantin Komarov
2021-09-27 15:28 ` [PATCH v2 3/3] fs/ntfs3: Refactoring of ntfs_set_ea Konstantin Komarov
2021-09-27 19:22 ` Kari Argillander
2021-09-27 19:39 ` Kari Argillander
2021-09-27 19:02 ` Kari Argillander [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210927190201.yhlipxcitremds3e@kari-VirtualBox \
--to=kari.argillander@gmail.com \
--cc=almaz.alexandrovich@paragon-software.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntfs3@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).