From: David Hildenbrand <david@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>, Dave Young <dyoung@redhat.com>,
Baoquan He <bhe@redhat.com>, Vivek Goyal <vgoyal@redhat.com>,
Michal Hocko <mhocko@suse.com>,
Oscar Salvador <osalvador@suse.de>,
Mike Rapoport <rppt@kernel.org>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
x86@kernel.org, xen-devel@lists.xenproject.org,
virtualization@lists.linux-foundation.org,
kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH v2 2/9] x86/xen: simplify xen_oldmem_pfn_is_ram()
Date: Tue, 5 Oct 2021 14:14:23 +0200 [thread overview]
Message-ID: <20211005121430.30136-3-david@redhat.com> (raw)
In-Reply-To: <20211005121430.30136-1-david@redhat.com>
Let's simplify return handling.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
arch/x86/xen/mmu_hvm.c | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/arch/x86/xen/mmu_hvm.c b/arch/x86/xen/mmu_hvm.c
index b242d1f4b426..d1b38c77352b 100644
--- a/arch/x86/xen/mmu_hvm.c
+++ b/arch/x86/xen/mmu_hvm.c
@@ -21,23 +21,10 @@ static int xen_oldmem_pfn_is_ram(unsigned long pfn)
.domid = DOMID_SELF,
.pfn = pfn,
};
- int ram;
if (HYPERVISOR_hvm_op(HVMOP_get_mem_type, &a))
return -ENXIO;
-
- switch (a.mem_type) {
- case HVMMEM_mmio_dm:
- ram = 0;
- break;
- case HVMMEM_ram_rw:
- case HVMMEM_ram_ro:
- default:
- ram = 1;
- break;
- }
-
- return ram;
+ return a.mem_type != HVMMEM_mmio_dm;
}
#endif
--
2.31.1
next prev parent reply other threads:[~2021-10-05 12:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-05 12:14 [PATCH v2 0/9] proc/vmcore: sanitize access to virtio-mem memory David Hildenbrand
2021-10-05 12:14 ` [PATCH v2 1/9] x86/xen: update xen_oldmem_pfn_is_ram() documentation David Hildenbrand
2021-10-05 12:14 ` David Hildenbrand [this message]
2021-10-05 19:26 ` [PATCH v2 2/9] x86/xen: simplify xen_oldmem_pfn_is_ram() Boris Ostrovsky
2021-10-05 12:14 ` [PATCH v2 3/9] x86/xen: print a warning when HVMOP_get_mem_type fails David Hildenbrand
2021-10-05 19:30 ` Boris Ostrovsky
2021-10-05 12:14 ` [PATCH v2 4/9] proc/vmcore: let pfn_is_ram() return a bool David Hildenbrand
2021-10-05 12:14 ` [PATCH v2 5/9] proc/vmcore: convert oldmem_pfn_is_ram callback to more generic vmcore callbacks David Hildenbrand
2021-10-05 12:14 ` [PATCH v2 6/9] virtio-mem: factor out hotplug specifics from virtio_mem_init() into virtio_mem_init_hotplug() David Hildenbrand
2021-10-05 12:14 ` [PATCH v2 7/9] virtio-mem: factor out hotplug specifics from virtio_mem_probe() " David Hildenbrand
2021-10-05 12:14 ` [PATCH v2 8/9] virtio-mem: factor out hotplug specifics from virtio_mem_remove() into virtio_mem_deinit_hotplug() David Hildenbrand
2021-10-05 12:14 ` [PATCH v2 9/9] virtio-mem: kdump mode to sanitize /proc/vmcore access David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211005121430.30136-3-david@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=boris.ostrovsky@oracle.com \
--cc=bp@alien8.de \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=jasowang@redhat.com \
--cc=jgross@suse.com \
--cc=kexec@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=osalvador@suse.de \
--cc=rafael.j.wysocki@intel.com \
--cc=rppt@kernel.org \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).