* [PATCH][next] coredump: Remove redundant initialization of variable core_waiters
@ 2021-10-11 13:16 Colin King
2021-10-12 10:39 ` Christian Brauner
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2021-10-11 13:16 UTC (permalink / raw)
To: Alexander Viro, linux-fsdevel; +Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable core_waiters is being initialized with a value that is never
read, it is being updated later on. The assignment is redundant and can
be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/coredump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/coredump.c b/fs/coredump.c
index a6b3c196cdef..2f79f8f7bd56 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -390,7 +390,7 @@ static int zap_threads(struct task_struct *tsk,
static int coredump_wait(int exit_code, struct core_state *core_state)
{
struct task_struct *tsk = current;
- int core_waiters = -EBUSY;
+ int core_waiters;
init_completion(&core_state->startup);
core_state->dumper.task = tsk;
--
2.32.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] coredump: Remove redundant initialization of variable core_waiters
2021-10-11 13:16 [PATCH][next] coredump: Remove redundant initialization of variable core_waiters Colin King
@ 2021-10-12 10:39 ` Christian Brauner
0 siblings, 0 replies; 2+ messages in thread
From: Christian Brauner @ 2021-10-12 10:39 UTC (permalink / raw)
To: Colin King; +Cc: Alexander Viro, linux-fsdevel, kernel-janitors, linux-kernel
On Mon, Oct 11, 2021 at 02:16:35PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable core_waiters is being initialized with a value that is never
> read, it is being updated later on. The assignment is redundant and can
> be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
Thanks!
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-12 10:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-11 13:16 [PATCH][next] coredump: Remove redundant initialization of variable core_waiters Colin King
2021-10-12 10:39 ` Christian Brauner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).