From: kernel test robot <lkp@intel.com>
To: Mikulas Patocka <mpatocka@redhat.com>, Christoph Hellwig <hch@lst.de>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Jens Axboe <axboe@kernel.dk>, Ming Lei <ming.lei@redhat.com>,
Zdenek Kabelac <zkabelac@redhat.com>,
linux-block@vger.kernel.org, dm-devel@redhat.com,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH v3] loop: don't print warnings if the underlying filesystem doesn't support discard
Date: Wed, 13 Oct 2021 13:06:31 +0800 [thread overview]
Message-ID: <202110131306.54mnKjv3-lkp@intel.com> (raw)
In-Reply-To: <alpine.LRH.2.02.2110121516440.21015@file01.intranet.prod.int.rdu2.redhat.com>
[-- Attachment #1: Type: text/plain, Size: 6578 bytes --]
Hi Mikulas,
I love your patch! Yet something to improve:
[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on kdave/for-next ceph-client/for-linus cifs/for-next tytso-ext4/dev jaegeuk-f2fs/dev-test mszeredi-fuse/for-next linus/master v5.15-rc5 next-20211012]
[cannot apply to hch-configfs/for-next gfs2/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Mikulas-Patocka/loop-don-t-print-warnings-if-the-underlying-filesystem-doesn-t-support-discard/20211013-042727
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: x86_64-randconfig-a015-20211012 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project adf55ac6657693f7bfbe3087b599b4031a765a44)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/c381403746bc0dc3eb5db4b157408430febd6ecf
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Mikulas-Patocka/loop-don-t-print-warnings-if-the-underlying-filesystem-doesn-t-support-discard/20211013-042727
git checkout c381403746bc0dc3eb5db4b157408430febd6ecf
# save the attached .config to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/cifs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> fs/cifs/cifsfs.c:1284:31: error: use of undeclared identifier 'FALLOC_FL_PUNCH_HOLE'
.fallocate_supported_flags = FALLOC_FL_PUNCH_HOLE |
^
>> fs/cifs/cifsfs.c:1285:3: error: use of undeclared identifier 'FALLOC_FL_ZERO_RANGE'
FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE |
^
>> fs/cifs/cifsfs.c:1285:26: error: use of undeclared identifier 'FALLOC_FL_KEEP_SIZE'
FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE |
^
>> fs/cifs/cifsfs.c:1286:3: error: use of undeclared identifier 'FALLOC_FL_COLLAPSE_RANGE'
FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE,
^
>> fs/cifs/cifsfs.c:1286:30: error: use of undeclared identifier 'FALLOC_FL_INSERT_RANGE'
FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE,
^
fs/cifs/cifsfs.c:1307:31: error: use of undeclared identifier 'FALLOC_FL_PUNCH_HOLE'
.fallocate_supported_flags = FALLOC_FL_PUNCH_HOLE |
^
fs/cifs/cifsfs.c:1308:3: error: use of undeclared identifier 'FALLOC_FL_ZERO_RANGE'
FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE |
^
fs/cifs/cifsfs.c:1308:26: error: use of undeclared identifier 'FALLOC_FL_KEEP_SIZE'
FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE |
^
fs/cifs/cifsfs.c:1309:3: error: use of undeclared identifier 'FALLOC_FL_COLLAPSE_RANGE'
FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE,
^
fs/cifs/cifsfs.c:1309:30: error: use of undeclared identifier 'FALLOC_FL_INSERT_RANGE'
FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE,
^
fs/cifs/cifsfs.c:1330:31: error: use of undeclared identifier 'FALLOC_FL_PUNCH_HOLE'
.fallocate_supported_flags = FALLOC_FL_PUNCH_HOLE |
^
fs/cifs/cifsfs.c:1331:3: error: use of undeclared identifier 'FALLOC_FL_ZERO_RANGE'
FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE |
^
fs/cifs/cifsfs.c:1331:26: error: use of undeclared identifier 'FALLOC_FL_KEEP_SIZE'
FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE |
^
fs/cifs/cifsfs.c:1332:3: error: use of undeclared identifier 'FALLOC_FL_COLLAPSE_RANGE'
FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE,
^
fs/cifs/cifsfs.c:1332:30: error: use of undeclared identifier 'FALLOC_FL_INSERT_RANGE'
FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE,
^
fs/cifs/cifsfs.c:1351:31: error: use of undeclared identifier 'FALLOC_FL_PUNCH_HOLE'
.fallocate_supported_flags = FALLOC_FL_PUNCH_HOLE |
^
fs/cifs/cifsfs.c:1352:3: error: use of undeclared identifier 'FALLOC_FL_ZERO_RANGE'
FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE |
^
fs/cifs/cifsfs.c:1352:26: error: use of undeclared identifier 'FALLOC_FL_KEEP_SIZE'
FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE |
^
fs/cifs/cifsfs.c:1353:3: error: use of undeclared identifier 'FALLOC_FL_COLLAPSE_RANGE'
FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE,
^
fatal error: too many errors emitted, stopping now [-ferror-limit=]
20 errors generated.
vim +/FALLOC_FL_PUNCH_HOLE +1284 fs/cifs/cifsfs.c
1265
1266 const struct file_operations cifs_file_ops = {
1267 .read_iter = cifs_loose_read_iter,
1268 .write_iter = cifs_file_write_iter,
1269 .open = cifs_open,
1270 .release = cifs_close,
1271 .lock = cifs_lock,
1272 .flock = cifs_flock,
1273 .fsync = cifs_fsync,
1274 .flush = cifs_flush,
1275 .mmap = cifs_file_mmap,
1276 .splice_read = generic_file_splice_read,
1277 .splice_write = iter_file_splice_write,
1278 .llseek = cifs_llseek,
1279 .unlocked_ioctl = cifs_ioctl,
1280 .copy_file_range = cifs_copy_file_range,
1281 .remap_file_range = cifs_remap_file_range,
1282 .setlease = cifs_setlease,
1283 .fallocate = cifs_fallocate,
> 1284 .fallocate_supported_flags = FALLOC_FL_PUNCH_HOLE |
> 1285 FALLOC_FL_ZERO_RANGE | FALLOC_FL_KEEP_SIZE |
> 1286 FALLOC_FL_COLLAPSE_RANGE | FALLOC_FL_INSERT_RANGE,
1287 };
1288
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 33439 bytes --]
next prev parent reply other threads:[~2021-10-13 5:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <alpine.LRH.2.02.2109231539520.27863@file01.intranet.prod.int.rdu2.redhat.com>
[not found] ` <20210924155822.GA10064@lst.de>
[not found] ` <alpine.LRH.2.02.2110040851130.30719@file01.intranet.prod.int.rdu2.redhat.com>
[not found] ` <20211012062049.GB17407@lst.de>
2021-10-12 20:25 ` [PATCH v3] loop: don't print warnings if the underlying filesystem doesn't support discard Mikulas Patocka
2021-10-13 2:56 ` kernel test robot
2021-10-13 5:06 ` kernel test robot [this message]
2021-10-13 9:28 ` [PATCH v4] " Mikulas Patocka
2021-10-27 5:02 ` Dave Chinner
2021-10-27 8:28 ` Mikulas Patocka
2021-10-28 4:15 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202110131306.54mnKjv3-lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=hch@lst.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=ming.lei@redhat.com \
--cc=mpatocka@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).